-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setup.py
#3143
Remove setup.py
#3143
Conversation
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES! I confirm both the wheels and the sdists are identical 👍🏽
Actually, there seems to be a difference when you install the package with |
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Changing the command to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪦 setup.py
Description
Remove
setup.py
and move remainder of content topyproject.toml
Closes part of #1498
Development notes
I ended up just removing the little bit of code iterating over
template_files
. This was added waaaaay back in Kedro version0.14.0
and has never been changed. I couldn't really figure out what it was doing.I ran
python -m build
on themain
branch and on this branch and compared the resulting tar files. The content is exactly the same. Unless I'm missing something I think that's sufficient proof that things are still working as expected even without thetemplate_files
stuff.Also updated the
pip install .
command in the e2e setup topip install -e .
.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file