Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py #3143

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Remove setup.py #3143

merged 4 commits into from
Oct 9, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 9, 2023

Description

Remove setup.py and move remainder of content to pyproject.toml

Closes part of #1498

Development notes

I ended up just removing the little bit of code iterating over template_files. This was added waaaaay back in Kedro version 0.14.0 and has never been changed. I couldn't really figure out what it was doing.

I ran python -m build on the main branch and on this branch and compared the resulting tar files. The content is exactly the same. Unless I'm missing something I think that's sufficient proof that things are still working as expected even without the template_files stuff.

Also updated the pip install . command in the e2e setup to pip install -e ..

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

merelcht and others added 3 commits October 6, 2023 17:21
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Oct 9, 2023
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! I confirm both the wheels and the sdists are identical 👍🏽

@merelcht
Copy link
Member Author

merelcht commented Oct 9, 2023

There seems to be a difference when you install the package with pip install ., which is making 2 of the e2e tests fail. I'll investigate!

Actually, there seems to be a difference when you install the package with pip install ., which is making 2 of the e2e tests fail. I'll investigate!

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Copy link
Member Author

merelcht commented Oct 9, 2023

Actually, there seems to be a difference when you install the package with pip install ., which is making 2 of the e2e tests fail. I'll investigate!

Changing the command to pip install -e . seems to have fixed it. This is mentioned as the command to use for installing the local directory.

@merelcht merelcht marked this pull request as ready for review October 9, 2023 14:01
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦 setup.py

@merelcht merelcht merged commit 6eb4402 into develop Oct 9, 2023
46 of 52 checks passed
@merelcht merelcht deleted the remove-setuppy branch October 9, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants