Migrate most project metadata to static pyproject.toml
#2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest adding @SajidAlamQB and @AhdraMeraliQB as reviewers, because they're leading the complete Move to |
antonymilne
approved these changes
Mar 30, 2023
Comment on lines
-18
to
-26
| # get package version | ||
| with open(path.join(here, name, "__init__.py"), encoding="utf-8") as f: | ||
| result = re.search(r'__version__ = ["\']([^"\']+)', f.read()) | ||
|
|
||
| if not result: | ||
| raise ValueError("Can't find the version in kedro/__init__.py") | ||
|
|
||
| version = result.group(1) | ||
|
|
There was a problem hiding this comment.
So pleased to see the back of this 😀
| [tool.setuptools.dynamic] | ||
| readme = {file = "README.md", content-type = "text/markdown"} | ||
| version = {attr = "kedro.__version__"} | ||
| dependencies = {file = "dependency/requirements.txt"} |
There was a problem hiding this comment.
@astrojuanlu How does pyproject.toml handle the tests' requirements?
There was a problem hiding this comment.
Test requirements don't exist anymore, they're replaced by the optional-dependencies (extras_requires in setuptools)
AhdraMeraliQB
approved these changes
Apr 3, 2023
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
See gh-2152. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
force-pushed
the
static-metadata
branch
from
5b798ff
to
2890254
Compare
MaximeSteinmetz
pushed a commit
to MaximeSteinmetz/kedro
that referenced
this pull request
Apr 3, 2023
) * Remove deprecated tests_require Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Migrate most project metadata to static pyproject.toml See kedro-orggh-2152. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Replace direct setup.py invokations by standard command Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: MaximeSteinmetz <maxime.steinmetz@gadz.org>
3 tasks
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address most of gh-2152, serve as a starting point for further efforts.
Development notes
Notice that https://github.com/asottile/setup-py-upgrade failed miserably, so I had to migrate everything manually. I followed these documentation pages:
Difference in
RECORD(files included in the wheel):differences in
METADATA:So, I'm quite confident that this is correct.
Checklist
RELEASE.mdfile