Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary test requirements #3144

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Oct 9, 2023

Description

Removed test requirements that are no longer needed now datasets have been removed.

Closes part of #1498

Development notes

  • Removed memory_profiler
  • Tried removing pyarrow, but that's still used by PartitionedDataset tests.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Oct 9, 2023
…from test reqs

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht marked this pull request as ready for review October 9, 2023 14:07
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I missed this one! 😛

@merelcht merelcht requested a review from lrcouto October 9, 2023 16:15
@merelcht merelcht enabled auto-merge (squash) October 10, 2023 10:07
@merelcht merelcht requested review from AhdraMeraliQB and removed request for SajidAlamQB October 10, 2023 11:28
@merelcht merelcht merged commit 1743dfb into develop Oct 11, 2023
46 of 52 checks passed
@merelcht merelcht deleted the cleanup-test-requirements branch October 11, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants