Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename add-ons to tools #189

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Rename add-ons to tools #189

merged 2 commits into from
Nov 29, 2023

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Nov 29, 2023

Motivation and Context

Part of www.github.com/kedro-org/kedro/issue/3054

🛑 This will stop the failing tests on Kedro's develop branch

Blocked by kedro-org/kedro#3357

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, however this will break several ongoing PRs, should we merge it now or wait?

@AhdraMeraliQB
Copy link
Contributor Author

LGTM 👍, however this will break several ongoing PRs, should we merge it now or wait?

Not merging it would leave Kedro's develop branch broken though 🤔

@SajidAlamQB
Copy link
Contributor

This is will break a lot of ongoing

LGTM 👍, however this will break several ongoing PRs, should we merge it now or wait?

Not merging it would leave Kedro's develop branch broken though 🤔

Oh sorry forgot that you merged in the rename on framework. In that case it needs to go in ASAP 😂

@AhdraMeraliQB AhdraMeraliQB merged commit 4718fad into main Nov 29, 2023
@AhdraMeraliQB AhdraMeraliQB deleted the chore/rename-addons-to-tools branch November 29, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants