Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename addons to tools #3357

Merged
merged 19 commits into from
Nov 29, 2023
Merged

Rename addons to tools #3357

merged 19 commits into from
Nov 29, 2023

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Nov 28, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Follow-on action from #3054

Development notes

Note: Ignore failing unit-tests. Unit tests will fail until changes go through on kedro-starters, it's a fun circular dependency 🔁

Blocked by :

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Ahdra Merali and others added 12 commits November 28, 2023 11:50
Update prompt order and language
6af6c57 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Update message on successful project creation
6421ab6 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Update existing tests
f7b533b 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Add check for example pipeline message
602e0c8 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Quick format
df8d66f 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Quick format pt2
0c9c829 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Apply suggestions from code review and fix lint
c5c828e 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Drop redundant comma
8423c5d 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@stichbury
Update prompts.yml
95c346f
@stichbury
Revert "Update prompts.yml"
c59a9da 
This reverts commit 95c346f.
@stichbury
This time signed-off
e7da825 
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Replace add-ons with tools
012d855 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Change short flag
135a1bd 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB marked this pull request as ready for review November 29, 2023 11:56
@AhdraMeraliQB AhdraMeraliQB mentioned this pull request Nov 29, 2023
Merged
3 tasks
AhdraMeraliQB and others added 3 commits November 29, 2023 13:43
@AhdraMeraliQB
Fix typo
4b6c2d6 
Signed-off-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
Merge develop into
6886030 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Lint
f8a0493 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Update kedro/templates/project/prompts.yml
b4c1210 
Signed-off-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
@AhdraMeraliQB
Update kedro/templates/project/prompts.yml
dc8ad6a 
Signed-off-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
merelcht
merelcht approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still mentions of add-ons in the RELEASE.md but otherwise LGTM 👍

kedro/framework/cli/starters.py Outdated
@@ -466,33 +466,33 @@ def _get_extra_context( # noqa: PLR0913
return extra_context


def _convert_addon_names_to_numbers(selected_add_ons_flag: str | None) -> str | None:
"""Prepares add-on selection from the CLI input to the correct format
def _convert_tools_names_to_numbers(selected_tools: str | None) -> str | None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
def _convert_tools_names_to_numbers(selected_tools: str | None) -> str | None:
def _convert_tool_names_to_numbers(selected_tools: str | None) -> str | None:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in d138efc

ankatiyar
ankatiyar approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Add changes from code review
d138efc 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB enabled auto-merge (squash) November 29, 2023 14:49
@AhdraMeraliQB AhdraMeraliQB linked an issue Nov 29, 2023 that may be closed by this pull request
Iterate on feedback on Project Creation Flow #3054
Closed
@merelcht merelcht merged commit 9f24ad6 into develop Nov 29, 2023
27 of 36 checks passed
@merelcht merelcht deleted the chore/rename-addons-to-tools branch November 29, 2023 16:11
@AhdraMeraliQB AhdraMeraliQB mentioned this pull request Nov 29, 2023
Closed
lrcouto pushed a commit that referenced this pull request Nov 30, 2023
@AhdraMeraliQB @lrcouto
Rename addons to tools (#3357)
16ef432 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
SajidAlamQB added a commit that referenced this pull request Dec 8, 2023
@SajidAlamQB @lrcouto @AhdraMeraliQB
Fix --tools=all not working properly (#3361)
074d5e1 
* add fix

* add fix

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Rename addons to tools (#3357)

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix broken tests (#3366)

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Fix variable names on _convert_tool_names_to_numbers

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Add tests for helper functions

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Lint

Signed-off-by: lrcouto <laurarccouto@gmail.com>

* Return numbers to tools names on conversion from all

Signed-off-by: lrcouto <laurarccouto@gmail.com>

---------

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com>
Co-authored-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
Co-authored-by: lrcouto <laurarccouto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankatiyar ankatiyar ankatiyar approved these changes

@merelcht merelcht merelcht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterate on feedback on Project Creation Flow
4 participants
@AhdraMeraliQB @merelcht @ankatiyar @stichbury