Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Python 3.11 #1502

Merged
merged 14 commits into from
Aug 29, 2023
Merged

Support for Python 3.11 #1502

merged 14 commits into from
Aug 29, 2023

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Aug 22, 2023 •
edited
Loading

Description

Resolves #1446

Development notes

  1. Included python 3.11 in the python_version matrix for build_backend job in CircleCI
  2. Modified make file commands (run and pytest) to include PYTHONWARNINGS
  3. Bumped python version to include 3.11 in the kedro-viz package setup

QA notes

  1. Navigate to kedro-viz project folder

  2. Checkout branch - feature/support-python_3.11

Local conda env setup for python 3.11 -

  • Create a conda environment with python 3.11 -

    conda create -n yourenvname python=3.11

  • Activate the created conda environment -

    conda activate yourenvname

Testing kedro-viz dev server -

  1. Install local kedro-datasets package by checking out kedro-plugins branch (bump/python-3.11-support) and executing the command -

    pip install -e kedro-datasets

Note: Since the kedro-datasets are not yet released to support py3.11, we are installing local version

  1. Install package dependencies for kedro-viz -

    pip3 install -r package/test_requirements.txt -r demo-project/src/docker_requirements.txt

  2. Run backend server by executing the command -

    make run

  3. Run frontend by executing the command -

    npm start

Testing kedro-viz as a package -

  1. Build frontend

     make build

  2. Install local Kedro-viz package -


    pip install -e package

  3. Navigate to demo-project - 


    cd demo-project

  4. Execute kedro viz command to open up in the browser here

     kedro viz

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@noklam
Copy link
Contributor

noklam commented Aug 23, 2023

I saw kedro-datasets installation is failing. It may require install from source temporarily for now because we have a deadlock if kedro don't release first kedro-dataset won't be available.

Do we need to discuss this offline?

@astrojuanlu
Copy link
Member

If I understand correctly, after merging kedro-org/kedro-plugins#297 and releasing kedro-datasets, everything should be fine. kedro can be already installed on Python 3.11. Am I missing something?

@ravi-kumar-pilla
Copy link
Contributor Author

I saw kedro-datasets installation is failing. It may require install from source temporarily for now because we have a deadlock if kedro don't release first kedro-dataset won't be available.

Do we need to discuss this offline?

Hi Nok, Happy to discuss, but Kedro-Viz can wait for Kedro-datasets to be released. @rashidakanchwala any thoughts on this ?

@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review August 25, 2023 13:28
rashidakanchwala
rashidakanchwala approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astrojuanlu astrojuanlu mentioned this pull request Aug 29, 2023
Closed
18 tasks
@ravi-kumar-pilla ravi-kumar-pilla merged commit 18f1220 into main Aug 29, 2023
1 check passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the feature/support-python_3.11 branch August 29, 2023 22:34
@rashidakanchwala rashidakanchwala mentioned this pull request Aug 31, 2023
Merged
5 tasks
ravi-kumar-pilla added a commit that referenced this pull request Aug 31, 2023
@ravi-kumar-pilla @noklam
Support for Python 3.11 (#1502)
d935065 
* initial draft for python 3.11 support

* update release doc

* add python warnings for e2e tests

* modify e2e test

* modify e2e test

* test by removing lower req scenario

* skip e2e tests for lower bound requirement on python 3.11

* skip e2e tests for lower bound requirement on python 3.11

* remove print statements

---------

Co-authored-by: Nok Lam Chan <nok_lam_chan@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
ravi-kumar-pilla added a commit that referenced this pull request Sep 11, 2023
@ravi-kumar-pilla @rashidakanchwala
@noklam @jitu5
Fix for Kedro Viz Connection Error (#1507)
335be7d 
* initial draft for resolving connection error

* refactor launchers and test code

* modify unit tests

* fix lint errors

* fix run_viz tests

* update unit test for coverage

* update unit tests

* Refactor visualize dataset stats from DataNodeMetadata to DataNode (#1499)

* add stats to data node

* lint and format check fix

* fix pytests

* fix layout issue

* fix transcoded data stats

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* initial draft for resolving connection error

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* Support for Python 3.11 (#1502)

* initial draft for python 3.11 support

* update release doc

* add python warnings for e2e tests

* modify e2e test

* modify e2e test

* test by removing lower req scenario

* skip e2e tests for lower bound requirement on python 3.11

* skip e2e tests for lower bound requirement on python 3.11

* remove print statements

---------

Co-authored-by: Nok Lam Chan <nok_lam_chan@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* Remove Python Upper Bound Requirements  (#1506)

* initial draft for python 3.11 support

* update release doc

* add python warnings for e2e tests

* modify e2e test

* modify e2e test

* test by removing lower req scenario

* skip e2e tests for lower bound requirement on python 3.11

* skip e2e tests for lower bound requirement on python 3.11

* remove python upperbounds initial draft

* fix lint and format errors

* test remove upperbound warning

* test lowerbound pandas install

* revert back pandas requirement

* bump lower requirements for pandas

* remove upper bound clean up

* update release notes

* fix PR comments

---------

Co-authored-by: Nok Lam Chan <nok_lam_chan@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* refactor launchers and test code

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* modify unit tests

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* fix lint errors

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* Fix: Adding favicon to Kedro Demo (#1509)

* Fix: Adding favicon to Kedro Demo

* Fix: Change in approach for serving favicon

* Lint error fix

* Lint error fix

* Favicon endpoint test added

* Favicon endpoint test added

* Lint error fixed

* Fix: Adding favicon to Kedro Demo

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Fix: Change in approach for serving favicon

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Lint error fix

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Lint error fix

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Favicon endpoint test added

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Favicon endpoint test added

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Lint error fixed

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>

* Fixed favicon endpoint test

* Release doc updated

* Update RELEASE.md

Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com>

* Removed pytest.fixture as per review comment

---------

Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* fix run_viz tests

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* update unit test for coverage

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* Release v6.5.0 (#1513)

* v6.5.0

* release

* update-reminder-content

* update reminder

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* remove branch condition for automate release version check (#1514)

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* update unit tests

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add release record

* modify comment

* fix PR comments

* DCO fix

* fixing dco

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* update pytest

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

---------

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Co-authored-by: Rashida Kanchwala <rashida.kanchwala@quantumblack.com>
Co-authored-by: Nok Lam Chan <nok_lam_chan@mckinsey.com>
Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com>
Co-authored-by: rashidakanchwala <37628668+rashidakanchwala@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu left review comments

@NeroOkwa NeroOkwa NeroOkwa approved these changes

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@tynandebold tynandebold Awaiting requested review from tynandebold

@yetudada yetudada Awaiting requested review from yetudada

@jitu5 jitu5 Awaiting requested review from jitu5

@vladimir-mck vladimir-mck Awaiting requested review from vladimir-mck

@noklam noklam Awaiting requested review from noklam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.11
5 participants
@ravi-kumar-pilla @noklam @astrojuanlu @rashidakanchwala @NeroOkwa