-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any version of Python (including 3.11) in metadata #2742
Conversation
f076020
to
090f2e0
Compare
Prompted by @idanov, I added a warning that by default is treated like an error:
And can be treated as a normal warning or ignored in two different ways (see https://docs.python.org/3/library/warnings.html#describing-warning-filters):
(custom categories can't be specified, see python/cpython#66733) |
75b5770
to
3f33046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
3f33046
to
24fee1b
Compare
Do we need to merge this in #2417? Not sure how we can test this without adding python 3.11 first, as the test will never be triggered in the CI and basically do nothing for 3.7 - 3.10. |
Merging this into gh-2417 doesn't really solve the bootstrapping problem (that there has to be a 3.11-enabled version to unblock the CI). On the other hand, the plan is to test these changes - it's just that we'll have to mock the |
good point👍 |
@astrojuanlu It turns out to be tricky with A few challenges here
Any idea how it could work? |
Ugh, I see what you mean. I'll give it some thought. |
The key is to not use
|
a0bc4b3
to
c0c5270
Compare
See https://iscinumpy.dev/post/bound-version-constraints/#pinning-the-python-version-is-special, and discussion in https://discuss.python.org/t/requires-python-upper-limits/12663?u=astrojuanlu, as well as practical problems with leaving the version cap on in #2270 (comment). Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
c0c5270
to
6295f27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great to me! 🚀 I think changing it to a warning when using unsupported Python versions is a good approach.
Thank you @astrojuanlu!
Thanks a bunch @SajidAlamQB ! This is going in |
🚀🚀🚀🚀 |
See https://iscinumpy.dev/post/bound-version-constraints/#pinning-the-python-version-is-special, and discussion in https://discuss.python.org/t/requires-python-upper-limits/12663?u=astrojuanlu, as well as practical problems with leaving the version cap on in #2270 (comment).
Deliberately not adding anything to the changelog, and not touching our CI systems either.
Checklist
RELEASE.md
file