Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: loosen the Python version requirement #276

Closed
wants to merge 1 commit into from

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Jul 20, 2023

Description

Start for #265

This won't have any direct impact as all plugins require kedro which is not available for 3.11. (That's why I didn't add the py3.11 test runner)
It does however loosen the circular dependency which we have now.

Frankly, there is little reason not to upgrade asap.
(Some datasets that are too slow to update can just be only available for 3.10)

Alternatively, remove the upper bound completely

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Simon Brugman <sfbbrugman@gmail.com>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even like having this upper bound in there, some past discussion:

https://iscinumpy.dev/post/bound-version-constraints/#pinning-the-python-version-is-special

(and also https://discuss.python.org/t/requires-python-upper-limits/12663?u=astrojuanlu)

So I'd rather evaluate whether we could lift the upper version uncapped for all the plugins, and whether we need something like kedro-org/kedro#2742 for, say, kedro-datasets (which is a bit hairy).

@sbrugman
Copy link
Contributor Author

sbrugman commented Aug 9, 2023

I agree. There isn't anything preventing us from doing so, is there?

@astrojuanlu
Copy link
Member

kedro-telemetry was already lifted in #292, and with kedro-datasets we want to be a bit more careful and the team has it on the radar #154

I'd say let's wait for Kedro 0.18.13 (which will have Python 3.11 support kedro-org/kedro#2851) and then let the team evaluate each plugin case by case. telemetry will probably be trivial, datasets not so much (although most of the heavy lifting has already been done), and no idea about docker and airflow.

@ankatiyar ankatiyar added the Community Issue/PR opened by the open-source community label Aug 22, 2023
@astrojuanlu
Copy link
Member

Better to close this PR and open one per remaining plugin, thanks @sbrugman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants