-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to React 18 #1652
Migrate to React 18 #1652
Conversation
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
… into chore/react_18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
One quick question: we were often getting dependabot alerts to upgrade react-scripts
from v4 to v5. Wonder if it's trivial to do that upgrade now in this PR?
@tynandebold Sure let me explore |
That would also address some platform-specific installation issues #1278 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works well locally ! Awesome job !!
@tynandebold I tried upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release 7.0.0 Major features and improvements Upgrade to React 18. (Migrate to React 18 #1652) Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671) Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz #1661) Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677) Drop support for python=3.7. (Remove support for Python 3.7 #1660) Drop support for kedro==0.17.x. (Drop Kedro 17 #1669) Bug fixes and other changes Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed. #1651) Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644) Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658) Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672) Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677) Fix bug on adding timestamps to shareable-viz. (_#1679)
Description
Migration of kedro-viz from React 17 to React 18
Breakdown of changes
Versionings:
Code changes
Development notes
Upgrading React 18 required updates to other dependencies (e.g. Redux, Adapter, removal and addition of some dependencies), as well as changes to existing codebase (as otherwise React would default back to 17 per its own API). Hence why the scope of this PR covers multiple dependency changes and large changes to codebase solely for this migration.
QA notes
Combination of existing E2E testing (via Cypress), and manual QA to cover areas that existing tests haven't covered yet