-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'Kedro Viz' to 'Kedro Viz Run' #1671
Conversation
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments, but generally this looks good 👍
Mistakenly wrote 'kedro run' instead of 'kedro viz' - commit changes it to be the latter Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Can you do a PR on the kedro
side as well to update the docs for mentions of kedro viz
after the release?
Sure @merelcht , happy to make a PR. There are changes made to docs in this PR which are related to viz docs as we have separated viz docs from Kedro. I am not sure exactly which other docs related to kedro needs an update. Let me have a look at it and if you have any suggestion, please let me know. Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks both!
Release 7.0.0 Major features and improvements Upgrade to React 18. (Migrate to React 18 #1652) Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671) Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz #1661) Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677) Drop support for python=3.7. (Remove support for Python 3.7 #1660) Drop support for kedro==0.17.x. (Drop Kedro 17 #1669) Bug fixes and other changes Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed. #1651) Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644) Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658) Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672) Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677) Fix bug on adding timestamps to shareable-viz. (_#1679)
Description
Resolves 1616 - changes 'kedro viz' to 'kedro viz run', making 'viz' into a command group
Development notes
Adjusts the cli.py files within the package folder, instructing to use 'viz run' going forward and making 'viz' into the new command group
QA notes
Can be tested normally via
npm test
, the e2e tests, and directly using the command group in the CLI