Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add official support for python 3.12 #2190

Merged
merged 31 commits into from
Nov 19, 2024
Merged

Add official support for python 3.12 #2190

merged 31 commits into from
Nov 19, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

Description

Adding official support for python 3.12

Development notes

  • Update workflows to include python 3.12 build
  • Update release note
  • Update version support warning

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
sync remote
8830cab
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
0a5d1ae
@ravi-kumar-pilla
merge main
bf47b47
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
13e905b
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
3d6326c
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
3d3bdda
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
1abfc43
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
1461a3c
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
c3f7cc6
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
1831a39
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
db14971
@ravi-kumar-pilla
merge main
93a7e28
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
a7592a2
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
493f5d1
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ab8a6b1
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
f715fdf
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
27c38dc
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
16a0435
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
5ccafb6
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
57f6ddf
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
b0a8575
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
41c93cb
@ravi-kumar-pilla
add python 3.12 support
a30d0e4
@ravi-kumar-pilla
fix permission
662da86
This was referenced Nov 15, 2024
Merged
Closed
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review November 19, 2024 15:32
rashidakanchwala
rashidakanchwala reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks had a first pass and left a few comments

rashidakanchwala
rashidakanchwala reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didnt test on 3.12 actually, but i did on 3.13 and it worked fine. @SajidAlamQB , can u test on 3.12 ?

@SajidAlamQB
Copy link
Contributor

can u test on 3.12 ?

I've tested viz on python 3.12 and it LGTM!

jitu5
jitu5 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravi-kumar-pilla

@ravi-kumar-pilla ravi-kumar-pilla merged commit e91d156 into main Nov 19, 2024
31 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the feature/python-3-12 branch November 19, 2024 20:04
@jitu5 jitu5 mentioned this pull request Nov 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala left review comments

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@jitu5 jitu5 jitu5 approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravi-kumar-pilla @SajidAlamQB @rashidakanchwala @jitu5