Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for python 3.12 #2190

Merged
merged 31 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
8830cab
sync remote
ravi-kumar-pilla Jul 28, 2024
0a5d1ae
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Jul 30, 2024
bf47b47
merge main
ravi-kumar-pilla Aug 8, 2024
13e905b
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Aug 13, 2024
3d6326c
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Aug 21, 2024
3d3bdda
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Aug 22, 2024
1abfc43
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 4, 2024
1461a3c
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 5, 2024
c3f7cc6
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 9, 2024
1831a39
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 12, 2024
db14971
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 17, 2024
93a7e28
merge main
ravi-kumar-pilla Sep 19, 2024
a7592a2
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 23, 2024
493f5d1
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 27, 2024
ab8a6b1
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Sep 30, 2024
f715fdf
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Oct 4, 2024
27c38dc
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Oct 8, 2024
16a0435
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Oct 10, 2024
5ccafb6
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Oct 21, 2024
57f6ddf
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Oct 30, 2024
b0a8575
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Nov 7, 2024
41c93cb
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Nov 15, 2024
a30d0e4
add python 3.12 support
ravi-kumar-pilla Nov 15, 2024
662da86
fix permission
ravi-kumar-pilla Nov 15, 2024
68ee45a
testing windows build
ravi-kumar-pilla Nov 18, 2024
51103c9
testing py3.12 with upgraded pandas
ravi-kumar-pilla Nov 18, 2024
f9f6600
testing python 3.12 and fsspec compat
ravi-kumar-pilla Nov 18, 2024
14c0280
final test
ravi-kumar-pilla Nov 19, 2024
c715c40
Merge branch 'main' into feature/python-3-12
ravi-kumar-pilla Nov 19, 2024
25dc06f
address PR comments
ravi-kumar-pilla Nov 19, 2024
8e751e8
Merge branch 'main' into feature/python-3-12
ravi-kumar-pilla Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/all-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/e2e-tests.yml
with:
os: ${{ matrix.os }}
Expand All @@ -24,7 +24,7 @@ jobs:
strategy:
matrix:
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/unit-tests.yml
with:
os: ${{ matrix.os }}
Expand All @@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/lint.yml
with:
os: ${{ matrix.os }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/e2e-tests.yml
with:
os: ${{ matrix.os }}
Expand All @@ -27,7 +27,7 @@ jobs:
strategy:
matrix:
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/unit-tests.yml
with:
os: ${{ matrix.os }}
Expand All @@ -37,7 +37,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/lint.yml
with:
os: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs-only-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11", "3.12" ]
uses: ./.github/workflows/lint.yml
with:
os: ${{ matrix.os }}
Expand Down
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Please follow the established format:

## Major features and improvements

- Add support for Python 3.12
- Update Kedro-Viz telemetry for opt-out model (#2022)
- Introduce `behaviour` prop object with `reFocus` prop (#2161)

Expand Down
2 changes: 1 addition & 1 deletion package/features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def before_scenario(context, scenario):

if (
kedro_version
and kedro_version <= parse("0.18.12")
and kedro_version < parse("0.18.12")
ravi-kumar-pilla marked this conversation as resolved.
Show resolved Hide resolved
and sys.version_info >= (3, 11)
):
print(
Expand Down
5 changes: 3 additions & 2 deletions package/features/steps/lower_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
ipython==7.0.0
fastapi==0.100.0
fsspec==2021.4
fsspec==2021.06.01
ravi-kumar-pilla marked this conversation as resolved.
Show resolved Hide resolved
aiofiles==22.1.0
uvicorn[standard]==0.22.0
watchfiles==0.24.0
plotly==4.8
packaging==23.0
pandas==1.3; python_version < '3.10'
pandas==1.5; python_version >= '3.10'
pandas==1.5; python_version >= '3.10' and python_version < '3.12'
ravi-kumar-pilla marked this conversation as resolved.
Show resolved Hide resolved
pandas==2.1.1; python_version >= '3.12'
sqlalchemy==1.4
strawberry-graphql==0.192.0
networkx==2.5
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class KedroVizPythonVersionWarning(UserWarning):
"""Custom class for warnings about incompatibilities with Python versions."""


if sys.version_info >= (3, 12):
if sys.version_info >= (3, 13):
warnings.warn(
"""Please be advised that Kedro Viz is not yet fully
compatible with the Python version you are currently using.""",
Expand Down
4 changes: 2 additions & 2 deletions package/tests/test_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@


def test_import_kedro_viz_with_no_official_support_emits_warning(mocker):
"""Test importing kedro Viz with python>=3.12 and controlled warnings should work"""
mocker.patch("kedro_viz.sys.version_info", (3, 12))
"""Test importing kedro Viz with python>=3.13 and controlled warnings should work"""
mocker.patch("kedro_viz.sys.version_info", (3, 13))

# We use the parent class to avoid issues with `exec_module`
with pytest.warns(UserWarning) as record:
Expand Down
Loading