Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize legal headers and LICENSE.md #366

Closed
deepyaman opened this issue May 11, 2020 · 1 comment
Closed

Standardize legal headers and LICENSE.md #366

deepyaman opened this issue May 11, 2020 · 1 comment
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@deepyaman
Copy link
Member

deepyaman commented May 11, 2020

Description

legal_header.txt (and the corresponding legal headers on top of source files) has nonstandard indentation on line 22 (middle line below):

# Trademarks or any confusingly similar mark as a trademark for your product,
#     or use the QuantumBlack Trademarks in any other manner that might cause
# confusion in the marketplace, including but not limited to in advertising,

Upon further investigation, this line isn't indented in LICENSE.md, but the Apache link is: https://github.com/quantumblacklabs/kedro/blob/d2d5ca1804d8a5b1d4ea2fe67ac09732e92956dc/LICENSE.md#L7

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Other users can sleep easy at night, no longer haunted by the fact that a random line is over-indented.

Issue also applies to https://github.com/quantumblacklabs/kedro-viz, https://github.com/quantumblacklabs/causalnex, etc.

Possible Implementation

See #365

Possible Alternatives

You can still keep legal_header.txt, if you foresee it diverging from LICENSE.md in the near future. I'd prefer to add it back later, if and when necessary, though.

@deepyaman deepyaman added the Issue: Feature Request New feature or improvement to existing feature label May 11, 2020
@921kiyo
Copy link
Contributor

921kiyo commented May 15, 2020

Resolved in 648f894 Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants