Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize legal headers to original LICENSE.md #365

Merged
merged 10 commits into from
May 15, 2020
Merged

Standardize legal headers to original LICENSE.md #365

merged 10 commits into from
May 15, 2020

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented May 11, 2020

Description

See #366

Development notes

make legal passes. Did some manual testing by including other directories like features (one of the files will fail due to having a non-ASCII apostrophe), one of the files in docs doesn't have a header.

The overall enhancements I made along the way:

  • It's not really necessary to check the single LICENSE.md file against a string in tools/licenses_and_headers.py; in fact, the tool can use LICENSE.md as the header source rather than maintaining yet another file for it (this is where the two got out of sync).
  • There's a mixture of writing generators and using non-lazy (hard-working?) methods like glob. The generator still gets fed directly to a list constructor, but c'est la vie.
  • Prefer sys.exit in a script to exit (see https://stackoverflow.com/questions/6501121/difference-between-exit-and-sys-exit-in-python or myriad other SO answers).

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@deepyaman deepyaman marked this pull request as ready for review May 11, 2020 06:45
@deepyaman deepyaman requested review from idanov and yetudada as code owners May 11, 2020 06:45
Copy link
Contributor

@921kiyo 921kiyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@mzjp2 mzjp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yetudada yetudada merged commit 648f894 into kedro-org:develop May 15, 2020
pull bot pushed a commit to FoundryAI/kedro that referenced this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants