-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize legal headers to original LICENSE.md
#365
Merged
yetudada
merged 10 commits into
kedro-org:develop
from
deepyaman:fix/standardize-license
May 15, 2020
Merged
Standardize legal headers to original LICENSE.md
#365
yetudada
merged 10 commits into
kedro-org:develop
from
deepyaman:fix/standardize-license
May 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
921kiyo
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
mzjp2
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #366
Development notes
make legal
passes. Did some manual testing by including other directories likefeatures
(one of the files will fail due to having a non-ASCII apostrophe), one of the files indocs
doesn't have a header.The overall enhancements I made along the way:
LICENSE.md
file against a string intools/licenses_and_headers.py
; in fact, the tool can useLICENSE.md
as the header source rather than maintaining yet another file for it (this is where the two got out of sync).glob
. The generator still gets fed directly to alist
constructor, but c'est la vie.sys.exit
in a script toexit
(see https://stackoverflow.com/questions/6501121/difference-between-exit-and-sys-exit-in-python or myriad other SO answers).Checklist
RELEASE.md
fileNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.