-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-3023] Enable plugins to extend starter-aliases default list #1592
Conversation
Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
It's in a good shape now and the PR should be functioning as it intended. Big thanks to @Galileo-Galilei to draft this PR initially and make it very easy for me to pick up. I plan to do a bit more refactoring, so this 56ee39c will be my checkpoint in case I fail to :). |
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
I am quite happy with the |
The Window e2etest is failing with a very subtle error. When |
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
…utomatic import Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
The CI was failing because of a bug, once we have the fix the PR should pass again. The bug was caused by the spawn process (Windows or MacOS >=3.8), because it will re-import everything. Thanks @AntonyMilneQB for getting to the bottom of this!
|
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
This reverts commit 611eedb. Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
…plugin-starter-alias Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@AntonyMilneQB Thanks a lot for your reviews! |
Signed-off-by: noklam nok.lam.chan@quantumblack.com
Description
Taking over the original PR from #1265, would fix #1040
Development notes
KedroStarterSpec
, the location is temp, it probably doesn't belongkedro.framework.cli.starters
The code can be run with
Todo
Screenshots
Checklist
RELEASE.md
file