Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patching pandas starter into official starter list #1667

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Patching pandas starter into official starter list #1667

merged 3 commits into from
Jul 4, 2022

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jul 4, 2022 •
edited
Loading

Signed-off-by: Nok Chan nok.lam.chan@quantumblack.com

Description

Found this while I am trying to do kedro new --starter=pandas-iris to test the rich logging😅.

This is a patch for #1592 where the pandas-iris starter is actually missed from the PR.

Development notes

  • Adding the pandas-iris KedroStarterSpec into the list

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file (No need since we haven't release a version yet)
  • Added tests to cover my changes

@noklam
Adding pandas-iris back
ec0c0cd 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam noklam marked this pull request as ready for review July 4, 2022 10:46
@noklam noklam requested a review from idanov as a code owner July 4, 2022 10:46
@noklam noklam requested review from antonymilne and removed request for idanov July 4, 2022 10:47
antonymilne
antonymilne approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... Good spot!

@noklam noklam requested a review from merelcht July 4, 2022 12:16
SajidAlamQB
SajidAlamQB approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@noklam noklam merged commit 3fc6a8e into main Jul 4, 2022
@noklam noklam deleted the fix/add-pandas-iris-starter branch July 4, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@antonymilne antonymilne antonymilne approved these changes

@merelcht merelcht Awaiting requested review from merelcht merelcht is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noklam @antonymilne @SajidAlamQB