Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing CI tests caused by new setuptools release #2269

Merged
merged 9 commits into from
Feb 2, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Jan 31, 2023

Signed-off-by: SajidAlamQB 90610031+SajidAlamQB@users.noreply.github.com

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

CI is failing on test_complex_requirements in test_micropkg_requirments.py due to the latest release of setuptools 67.0.0 which has made some changes to pkg_resources. Adding an upper bound to setuptools pin resolves it for now.

Development notes

Pinned setuptools>=65.5.1, <67.0.0
Fixed PyLint errors example, instead of dict() use literals {...}
Pinned jupyterlab~=3.0, <3.6.0 as 3.6.0 requires jupyterlab_server~=2.19

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@SajidAlamQB SajidAlamQB self-assigned this Jan 31, 2023
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@SajidAlamQB SajidAlamQB marked this pull request as ready for review January 31, 2023 16:16
@SajidAlamQB SajidAlamQB requested a review from idanov as a code owner January 31, 2023 16:16
@SajidAlamQB SajidAlamQB changed the title Fix Failing CI tests caused by setuptools Fix Failing CI tests caused by new setuptools release Jan 31, 2023
@astrojuanlu
Copy link
Member

Is there a link to a failing CI job that shows the failure? Or, alternatively, what's exactly the error message?

@SajidAlamQB
Copy link
Contributor Author

Is there a link to a failing CI job that shows the failure? Or, alternatively, what's exactly the error message?

It's failing for all PRs here's an example. You can recreate it manually by running the tests locally as well. The actual test that's failing is test_complex_requirements in test_micropkg_requirements.py here.

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sufficient solution for now, but we should add an issue and prioritise fixing this properly. Ideally we don't have to bound things like pip or setuptools.

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
@SajidAlamQB SajidAlamQB requested review from ankatiyar and removed request for jmholzer February 1, 2023 10:56
stichbury and others added 5 commits February 2, 2023 09:53
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants