-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upper bound for jupyterlab
in kedro-starters
and default template
#2276
Comments
flake8 5.0 still pins and then flake8 6.0 requires Python >=3.8.1 https://github.com/PyCQA/flake8/blob/b9a7794c4f425ef8419081e6993f99419cc667ea/setup.cfg#L40-L41 So I guess the only solution is to jump to flake8 6.x. But we won't be able to do that until later this year #2158 |
setuptools
and jupyterlab
is breaking some of our testsjupyterlab
To note: JupyterLab 4.0 will be out soon, with major improvements. Pending user-friendly changelog jupyterlab/jupyterlab#14060 Maybe instead of waiting until we drop Python 3.7, we could do some selective requirements pinning depending on the Python version? i.e. we pin |
One more question - trying to understand the pinning policy. Do we somehow pin in our CI the same as the requirements that are shipped in the default template? kedro/kedro/templates/project/{{ cookiecutter.repo_name }}/src/requirements.txt Lines 6 to 8 in 7f44733
|
JupyterLab 4.0 is available https://pypi.org/project/jupyterlab/4.0.0/ |
See more context in #2700 (closed in favour of this one) |
jupyterlab
jupyterlab
in `kedro-starters
Updated title to reflect the requirements, kedro doesn't have dependency on jupyter, it is only requirements in the starters. |
#3072 lifted some of the upper bounds in framework |
jupyterlab
in `kedro-startersjupyterlab
in kedro-starters
and default template
This is how the dependencies of the default template look like now:
I think ideally we should
|
See #2276. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
See #2276. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
See #2276. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
* More flexible pinning of Jupyter optional dependencies See #2276. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add Jupyter changes to release notes Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add future note about problematic test code Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Restore notebook dependency Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Restore ipython lower bound Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Update Jupyter liveness test Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add small pause after server aliveness check Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
See kedro-org/kedro#2276 and kedro-org/kedro#3288 Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Follow-up in kedro-starters at kedro-org/kedro-starters#200 |
See kedro-org/kedro#2276 and kedro-org/kedro#3288 Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
See kedro-org/kedro#2276 and kedro-org/kedro#3288 Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Following #2269
setuptools
was pinned with an upper bound<67.0.0
as a temporary solution to avoid CI failures. We should investigate why the latest version ofsetuptools
is breaking our CI.Furthermore, in the same PR
jupyterlab
was also pinned with an upper bound<3.6.0
as it requiredjupyterlab_server~=2.19
but our requirements.txt contains:jupyterlab_server>=2.11.1, <2.16.0 # 2.16.0 requires importlib_metedata >= 4.8.3 which conflicts with flake8 requirement
The text was updated successfully, but these errors were encountered: