Loosen Jupyter pinning #3288
Merged
Loosen Jupyter pinning #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e2e tests failed, converting to draft |
noklam
reviewed
Nov 9, 2023
features/steps/test_starter/{{ cookiecutter.repo_name }}/requirements.txt
Show resolved
Hide resolved
astrojuanlu
commented
Nov 9, 2023
features/steps/test_starter/{{ cookiecutter.repo_name }}/requirements.txt
Show resolved
Hide resolved
astrojuanlu
commented
Nov 9, 2023
astrojuanlu
force-pushed
the
jupyter-pinning
branch
5 times, most recently
from
d972260 to
fae7f35
Compare
noklam
approved these changes
Dec 11, 2023
merelcht
reviewed
Dec 18, 2023
| @@ -391,9 +391,12 @@ def exec_notebook(context, command): | |||
| @then('I wait for the jupyter webserver to run for up to "{timeout:d}" seconds') | |||
| def wait_for_notebook_to_run(context, timeout): | |||
| timeout_start = time() | |||
| # FIXME: Will continue iterating after the process has returned | |||
There was a problem hiding this comment.
It's stating that there's a flaw in the current logic, but I didn't have time to fix it 😅
See #2276. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
force-pushed
the
jupyter-pinning
branch
from
fae7f35 to
300c27b
Compare
|
Changed target branch 👍🏽 |
astrojuanlu
added a commit
to kedro-org/kedro-starters
that referenced
this pull request
Dec 20, 2023
See kedro-org/kedro#2276 and kedro-org/kedro#3288 Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
3 tasks
astrojuanlu
added a commit
to kedro-org/kedro-starters
that referenced
this pull request
Dec 20, 2023
See kedro-org/kedro#2276 and kedro-org/kedro#3288 Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
to kedro-org/kedro-starters
that referenced
this pull request
Dec 20, 2023
See kedro-org/kedro#2276 and kedro-org/kedro#3288 Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Got hit by #2276 because of something else, went ahead and did the change.
Development notes
Followed everything in #2276, except for bumping the minimum requirement of
notebook(hence making this a non-breaking change)Ideally, to close #2276 this would need to be replicated in the starters too.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile