Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible pinning of Jupyter optional dependencies #200

Merged
merged 1 commit into from
Dec 20, 2023
Merged

More flexible pinning of Jupyter optional dependencies #200

merged 1 commit into from
Dec 20, 2023

Conversation

astrojuanlu
Copy link
Member

See kedro-org/kedro#2276 and kedro-org/kedro#3288

Motivation and Context

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@astrojuanlu astrojuanlu mentioned this pull request Dec 20, 2023
Closed
merelcht
merelcht approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@astrojuanlu astrojuanlu enabled auto-merge (squash) December 20, 2023 11:41
@astrojuanlu astrojuanlu disabled auto-merge December 20, 2023 11:43
@astrojuanlu
Copy link
Member Author

pip doing some heavy backtracking on kedro-datasets:

WARNING: kedro-datasets 1.8.0 does not provide the extra 'hdfs-base'
WARNING: kedro-datasets 1.8.0 does not provide the extra 's3fs-base'
WARNING: kedro-datasets 1.8.0 does not provide the extra 'spark-base'

@noklam

This comment was marked as resolved.

Sign in to view
@astrojuanlu
More flexible pinning of Jupyter optional dependencies
a9da479 
See kedro-org/kedro#2276
and kedro-org/kedro#3288

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu astrojuanlu force-pushed the loosen-jupyter-pinning branch from b1ef701 to a9da479 Compare December 20, 2023 16:22
@astrojuanlu astrojuanlu enabled auto-merge (squash) December 20, 2023 16:22
@astrojuanlu astrojuanlu merged commit 030bbed into main Dec 20, 2023
36 checks passed
@astrojuanlu astrojuanlu deleted the loosen-jupyter-pinning branch December 20, 2023 16:59
@noklam
Copy link
Contributor

noklam commented Dec 21, 2023 •
edited
Loading

The issue was fixed separately in #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@noklam noklam noklam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrojuanlu @noklam @merelcht