Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirements from removed CLI commands #3072

Merged
merged 11 commits into from
Sep 26, 2023
Merged

Remove requirements from removed CLI commands #3072

merged 11 commits into from
Sep 26, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Sep 25, 2023 •
edited
Loading

Description

#1725

Development notes

Remove:

  • nbstripout requirement
  • pylint requirements, setup and left over mentions
  • isort setup and requirement
  • flake8 setup and requirement

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@merelcht
Remove nbstripout from requirements
ae07094 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Remove pylint from requirements
5a0132d 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Remove any left-over pylint:... statements
04eeee0 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht changed the base branch from main to develop September 25, 2023 09:28
@merelcht
Remove isort setup + mentions
49fa81d 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Remove flak8 setup and requirements
b153103 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Update files in template
f79a6b2 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Try remove upper bound jupyter reqs
56370d2 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
fix link
e0e8f7e 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Remove all recommendations for flake8, pylint, isort
686ed60 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht linked an issue Sep 25, 2023 that may be closed by this pull request
Remove dependencies only needed for development related CLI commands #1725
Closed
@merelcht merelcht marked this pull request as ready for review September 25, 2023 15:43
@merelcht merelcht requested review from noklam and removed request for yetudada September 25, 2023 15:44
@merelcht merelcht self-assigned this Sep 25, 2023
stichbury
stichbury approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

merelcht and others added 2 commits September 26, 2023 10:05
@merelcht
Update databricks links
23751a0 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Merge branch 'develop' into remove-old-requirements
89298de
@merelcht merelcht enabled auto-merge (squash) September 26, 2023 09:16
@merelcht merelcht merged commit 612ee4e into develop Sep 26, 2023
@merelcht merelcht deleted the remove-old-requirements branch September 26, 2023 10:06
This was referenced Sep 26, 2023
Merged
Closed
Merged
This was referenced Sep 26, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stichbury stichbury stichbury approved these changes

@noklam noklam noklam approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependencies only needed for development related CLI commands
3 participants
@merelcht @stichbury @noklam