Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin setuptools and fix test #2279

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Unpin setuptools and fix test #2279

merged 3 commits into from
Feb 3, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Feb 3, 2023 •
edited
Loading

Signed-off-by: Merel Theisen merel.theisen@quantumblack.com

Description

Solves part of #2276

Development notes

In the latest setuptools release they made breaking changes related to requirements parsing:
https://setuptools.pypa.io/en/stable/history.html#v67-0-0

As a consequence some of the error messages changed. I updated those accordingly in our tests.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@merelcht merelcht requested a review from idanov as a code owner February 3, 2023 16:29
@merelcht merelcht requested a review from yetudada as a code owner February 3, 2023 16:31
@merelcht merelcht self-assigned this Feb 3, 2023
@merelcht
Unpin setuptools and fix test
d672fd8 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Fix link + update release notes
46be003 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Fix assert statement
60bc6b1 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
astrojuanlu
astrojuanlu approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merelcht merelcht merged commit 211f48d into main Feb 3, 2023
@merelcht merelcht deleted the fix/setuptools branch February 3, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @astrojuanlu @SajidAlamQB