Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pip attempt 2 #2828

Closed
wants to merge 18 commits into from
Closed

Fix/pip attempt 2 #2828

wants to merge 18 commits into from

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jul 21, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

noklam added 14 commits July 18, 2023 13:46
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…org/kedro into fix/ci-breaking-pip-tools

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Copy link
Contributor Author

noklam commented Jul 21, 2023

Trying to fix pip version as I notice win 3.7 use pip 22.1.2 but all other tests are installing with 23.1.2

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Copy link
Contributor Author

noklam commented Jul 24, 2023

Try to re-order the CI steps as I notice "Conda install PyTable, GDAL, Fiona" override pip version.

      - run:
          name: Install GDAL, Fiona and pytables
          command: conda activate kedro_builder; conda install gdal fiona pytables -c conda-forge -y
      - run:
          name: Install pip setuptools
          command: conda activate kedro_builder; make install-pip-setuptools

noklam added 2 commits July 24, 2023 11:17
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@AhdraMeraliQB AhdraMeraliQB changed the base branch from main to fix/ci-breaking-pip-tools July 25, 2023 10:09
@noklam
Copy link
Contributor Author

noklam commented Jul 26, 2023

Closed in favor of #2843

@noklam noklam closed this Jul 26, 2023
@merelcht merelcht deleted the fix/pip-attempt-2 branch October 25, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant