-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pip < 23.2 and Port unit tests, lint and e2e tests to Github Actions unblock CI #2843
Conversation
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
I love how the setup is so much shorter on Github Action and it's easier to refactor the logic into smaller files. |
Yeah, I had already created a commit 😅 so I just wanted to check if the tests are working as expected before I add it back in. Reverting the change to |
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Yes - I am confident the Github Action works, but just to stay on the safe side, we will keep Github Action & CircleCI run in parallel, but remove the checks from CircleCI. @merelcht |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, so excited about this 🙌
@@ -0,0 +1,24 @@ | |||
name: Run checks on Kedro Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe redundant with Read the Docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the current behaviour for now. I think read the docs errors are very hard to find 😅
Minor nitpicks: I would probably rename |
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @ankatiyar ⭐ 💪 Probably also worth mentioning this in the release notes for our own reference.
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Description
To unblock the CI 😄
Development notes
pip
->pip<23.2
kedro-tests.yml
calls the tests inlint-tests.yml
,unit-tests.yml
ande2e-tests.yml
kedro-docs-only.yml
callslint-tests.yml
for python 3.7-3.10Checklist
RELEASE.md
file