Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try pinning dependencies #2836

Closed

Conversation

AhdraMeraliQB
Copy link
Contributor

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

See #2816 (comment)

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Ahdra Merali added 2 commits July 25, 2023 11:12
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@AhdraMeraliQB
Copy link
Contributor Author

Interestingly in this PR all tests get the same error consistently.

Windows 3.8 and 3.9 are failing because of a purposefully wrong assert (assert exit_code is 2) at the minute, not the same error as 3.7. Changed the assert to differentiate them to see specifically on which 3.7 was failing

@astrojuanlu
Copy link
Member

Closing this in favor of #2843

@astrojuanlu astrojuanlu deleted the fix/try-pin-dependencies branch July 26, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants