-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pip < 23.2 and Port unit tests, lint and e2e tests to Github Actions unblock CI #2843
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
809002b
port tests to GA
ankatiyar 5f6c8fb
Revert changes to CircleCI config
ankatiyar 06b74c2
Revert changes to CircleCI config
ankatiyar 2dcb4bc
Suggestions from code review
ankatiyar ad8b103
Suggestions from code review
ankatiyar 2875112
Create merge-gatekeeper.yml
noklam 368174e
Update release notes
ankatiyar 561115b
Merge branch 'port-ci' of https://github.com/kedro-org/kedro into por…
ankatiyar 4dc6552
Merge branch 'main' into port-ci
noklam 2f330ad
Update merge-gatekeeper.yml
noklam 6bd5219
Update merge-gatekeeper.yml
noklam dabe869
Update merge-gatekeeper.yml
noklam 58eff03
Update merge-gatekeeper.yml
noklam b3a9189
Update merge-gatekeeper.yml
noklam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
name: Run e2e-tests on Kedro | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
os: | ||
type: string | ||
python-version: | ||
type: string | ||
|
||
env: | ||
COLUMNS: 120 | ||
LINES: 25 | ||
|
||
jobs: | ||
e2e-tests: | ||
runs-on: ${{ inputs.os }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Set up Python ${{inputs.python-version}} | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: ${{inputs.python-version}} | ||
- run: make install-pip-setuptools | ||
- name: Cache python packages for Linux | ||
if: inputs.os == 'ubuntu-latest' | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~/.cache/pip | ||
key: ${{inputs.os}}-python-${{inputs.python-version}} | ||
- name: Cache python packages for Windows | ||
if: inputs.os == 'windows-latest' | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~\AppData\Local\pip\Cache | ||
key: ${{inputs.os}}-python-${{inputs.python-version}} | ||
- name: Install dependencies | ||
run: | | ||
pip --version | ||
make install-test-requirements | ||
make install-pre-commit | ||
- name: pip freeze | ||
run: pip freeze | ||
- name: Run e2e tests | ||
run: make e2e-tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: Run checks on Kedro Docs | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
paths: | ||
- "docs/**" | ||
pull_request: | ||
branches: | ||
- main | ||
paths: | ||
- "docs/**" | ||
|
||
jobs: | ||
lint-tests: | ||
strategy: | ||
matrix: | ||
os: [ ubuntu-latest ] | ||
python-version: [ "3.7", "3.8", "3.9", "3.10" ] | ||
uses: ./.github/workflows/lint-tests.yml | ||
with: | ||
os: ${{ matrix.os }} | ||
python-version: ${{ matrix.python-version }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: Run checks on Kedro | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
paths-ignore: | ||
- "docs/**" | ||
pull_request: | ||
branches: | ||
- main | ||
paths-ignore: | ||
- "docs/**" | ||
|
||
jobs: | ||
unit-tests: | ||
strategy: | ||
matrix: | ||
os: [ ubuntu-latest, windows-latest ] | ||
python-version: [ "3.7", "3.8", "3.9", "3.10" ] | ||
uses: ./.github/workflows/unit-tests.yml | ||
with: | ||
os: ${{ matrix.os }} | ||
python-version: ${{ matrix.python-version }} | ||
|
||
lint-tests: | ||
strategy: | ||
matrix: | ||
os: [ ubuntu-latest ] | ||
python-version: [ "3.8" ] | ||
uses: ./.github/workflows/lint-tests.yml | ||
with: | ||
os: ${{ matrix.os }} | ||
python-version: ${{ matrix.python-version }} | ||
|
||
e2e-tests: | ||
strategy: | ||
matrix: | ||
os: [ ubuntu-latest, windows-latest ] | ||
python-version: [ "3.7", "3.8", "3.9", "3.10" ] | ||
uses: ./.github/workflows/e2e-tests.yml | ||
with: | ||
os: ${{ matrix.os }} | ||
python-version: ${{ matrix.python-version }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: Run linters on Kedro | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
os: | ||
type: string | ||
python-version: | ||
type: string | ||
|
||
jobs: | ||
lint: | ||
runs-on: ${{ inputs.os }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Set up Python 3.8 | ||
ankatiyar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: ${{ inputs.python-version }} | ||
- name: Cache python packages | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~/.cache/pip | ||
key: ${{inputs.os}}-python-${{inputs.python-version}} | ||
- name: Install dependencies | ||
run: | | ||
make install-test-requirements | ||
make install-pre-commit | ||
pip freeze | ||
- name: Run linter | ||
run: make lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
name: Run unit-tests on Kedro | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
os: | ||
type: string | ||
python-version: | ||
type: string | ||
jobs: | ||
unit-tests: | ||
runs-on: ${{ inputs.os }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Set up Python ${{inputs.python-version}} | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: ${{inputs.python-version}} | ||
- run: make install-pip-setuptools | ||
- name: Cache python packages for Linux | ||
if: inputs.os == 'ubuntu-latest' | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~/.cache/pip | ||
key: ${{inputs.os}}-python-${{inputs.python-version}} | ||
- name: Cache python packages for Windows | ||
if: inputs.os == 'windows-latest' | ||
uses: actions/cache@v3 | ||
with: | ||
path: ~\AppData\Local\pip\Cache | ||
key: ${{inputs.os}}-python-${{inputs.python-version}} | ||
- name: Install dependencies | ||
run: | | ||
make install-test-requirements | ||
make install-pre-commit | ||
- name: Install pytables (only for windows) | ||
if: inputs.os == 'windows-latest' | ||
run: pip install tables | ||
- name: pip freeze | ||
run: pip freeze | ||
- name: Run unit tests | ||
if: inputs.os == 'ubuntu-latest' && inputs.python-version == '3.10' | ||
run: make test-sequential | ||
- name: Run unit tests | ||
if: inputs.os == 'ubuntu-latest' && inputs.python-version != '3.10' | ||
run: make test | ||
- name: Run unit tests (Windows) | ||
if: inputs.os == 'windows-latest' && inputs.python-version == '3.10' | ||
run: make test-no-spark-sequential | ||
- name: Run unit tests (Windows) | ||
if: inputs.os == 'windows-latest' && inputs.python-version != '3.10' | ||
run: make test-no-spark |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe redundant with Read the Docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the current behaviour for now. I think read the docs errors are very hard to find 😅