-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.2.1 (official release) #121
Conversation
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
@noklam Will it be useful to track who is installing and canceling "Kedro-Viz" dependency in telemetry ? |
We cannot track who is installing since that's personal information. I think it's more important to know if people are cancelling because of bug or it doesn't work, the usage of the installation is not too important since we are not going to remove it simply because people are not clicking on it. |
One thing that I want to improve though, is a little bit more help or at least guide user to report the issue when the server didn't start properly. I think that's the most frustrating part for now, since it doesn't do anything and user have little information about what's going on. Based on some previous chat a few users have installed it but it didn't worked for their project so they didn't use the extension. Sometimes it's simply because they are not opening the workspace or missing dependencies to start the extension. (This is separated and we don't need to block this for the release, just something to consider in the future). |
On similar line we also need to fix those panic errors when not on a Kedro project. |
Good point, I want to spare some time after this feature release on more bug fix, UX improvement and start adding some tests. |
Right after opening my IDE I found this error:
vscode-kedro/bundled/tool/lsp_server.py Line 75 in 8ed1f30
It was indeed solved by setting the correct Python interpreter.
I get the "missing dependency" prompt, click "Install", I get an info message saying "Kedro-Viz and its Dependencies installed successfully!", and then nothing happens ❓ I run Run Viz again and I get the same prompt. Looking at the output, I get "No module named pip", which makes a ton of sense because my environment doesn't have pip installed ( I eventually solved it by doing I now see a black screen though, and nothing meaningful in the output. |
@astrojuanlu About the blank screen, LSP server error log coming from Kedro-Viz was missing and just print statement was added, we will fix this before final release. In one of my Kedro project I also got blank screen, on debug I found "Class 'pandas.CSVDataset' not found" error. Which kedro project are you using ? |
I was using a WIP version of https://github.com/astrojuanlu/kedro-pypi-monitor, not sure if you'll be able to reproduce. Let me know when I can try a version with logs. |
@astrojuanlu I tried and able to reproduce same blank screen and in log I got below error. I have a extension with log, you have to install it. I can share in in Slack.
Also I tried running |
Thanks, looks like problem was between chair and keyboard then! Any chance to show an error message instead of a blank screen? Or at least an error notification like "couldn't display Kedro Viz, check logs" |
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still reviewing some other things.
But I also got a blank Kedro-viz screen initially, and Nok showed me how I need to go to Outputs
on VSCode, select Kedro
to understand what error was being thrown. Not sure, if others will also face the same issue and know where to find the error logs.
@noklam @astrojuanlu |
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
looks good for me, I notice this seems to be a common thing to do among extensions, maybe it's even better make this one step instead of Output -> Kedro? We will need to update the README.md to reflect the troubleshoot section too. They all implement a simple command that directly go to the extension outputs, for example: |
@noklam If we can directly open Kedro output check with command, So I make a link, by clicking on that user will directly jump to Kedro output logs |
That's look smooooth |
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship ittttttt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is suppper exciting!
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
…o 0.2.0 Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
…o 0.2.0 Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Updated release title to be 0.2.1 since the VSCode extension treat pre-release as an official release and not allow the same version name. |
Updated the contribution point so this is now a public facing command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to install
fix #88
you can install pre-release version of extension from marketplace directly:
Install
buttonHow to test
Make sure you open VSCode at the root of a Kedro project
Make sure VSCode is using the correct virtual environment, i.e. the environment that you can do
kedro run
Bonus: Start a fresh new environment, kedro project to test because we need to make sure dependencies is not a problem. We added a new flow in case user are missing certain dependencies.
Test Kedro: Run Viz
playaround with namespace, non spaceflights project structure.
Make sure kedro-viz is an optional dependency and don't crash the server. #71