Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence errors when not on a Kedro project #77

Closed
Tracked by #58
astrojuanlu opened this issue Aug 25, 2024 · 8 comments
Closed
Tracked by #58

Silence errors when not on a Kedro project #77

astrojuanlu opened this issue Aug 25, 2024 · 8 comments
Assignees
Labels
bug Something isn't working UX Improved UX include performance, hotreload

Comments

@astrojuanlu
Copy link
Member

image

I get these errors when not on a Kedro project, which are mildly annoying. Not a big deal but wondering if we could make it more subtle.

Or, say, make them visible when we know it's a Kedro project but it seems to be broken for some reason.

@noklam
Copy link
Contributor

noklam commented Sep 11, 2024

^ Possible, right now the server initialised when someone click on a Python or YAML server I think. There maybe a more generic pattern we can use to avoid these signals. It's likely there are limitations as this is controlled by VSCode and we cannot write arbitrary code. We can stop throwing the error but we need to know think about how does user actually know the server is not working otherwise.

@noklam noklam added UX Improved UX include performance, hotreload bug Something isn't working and removed UX Improved UX include performance, hotreload labels Sep 23, 2024
@noklam noklam moved this to Todo in Kedro VS Code Sep 25, 2024
@datajoely
Copy link

Same issue as #77 ? We need better way to discover Kedro project #53, but making is less noisy can be done before this.
image
Ideally I want something like "Mark this as Kedro Project"

@noklam replying to comment on #137 here - I think for MVP you just need to do something on the VS Cod command palette - probably both "Disable for this project" and "Mark this project as Kedro" (the second one perhaps needs a fine grained working directory option)

image

@datajoely
Copy link

I want to reiterate I think there is a substantial risks users uninstall the extension because it's noisy and distracts you when you're working on something else. I've been working in FastAPI for the last week and I close the pop up every time I open the IDE.

@noklam
Copy link
Contributor

noklam commented Oct 7, 2024

probably both "Disable for this project" and "Mark this project as Kedro" (the second one perhaps needs a fine grained working directory option)

Just confirming my understanding - those warnings are now showing up everytime you open a new VSCode, it should stops showing up once you get the pop up as it will automatically stop restarting the server after a few retry. Would people be bother to run a command and disable Kedro specifically for one project? (also, what is the notion of a "project"? I do not want to introduce a new metadata file so it's tricky for the extension to know what exactly is a project, unless user is using a vscode workspace).

The alternative is it's disable by default but need a command to activate the extension (or at some point this get better so the extension can auto-discover the pyproject.toml to locate the tool.kedro section).

@datajoely
Copy link

I think there are two ways in mind:

  • Provide a mechanism for the extension to learn and project isn't Kedro. (Reactive)
  • Use a popup to say, "this looks like a Kedro project - enable extension?" (Proactive)

@noklam noklam changed the title Be more silent when not on a Kedro project? [Spike]: Be more silent when not on a Kedro project? Oct 7, 2024
@astrojuanlu astrojuanlu changed the title [Spike]: Be more silent when not on a Kedro project? Silence errors when not on a Kedro project Nov 4, 2024
@astrojuanlu
Copy link
Member Author

As a first, easy step we want to silence the error.

In parallel we'll open a separate issue to have a smarter way of detecting the Kedro project so that we don't even instantiate the LSP if we cannot do so.

@datajoely
Copy link

image

this is a scary error message we could handle more gracefully

@SajidAlamQB
Copy link
Contributor

Completed in: #154

@github-project-automation github-project-automation bot moved this from Todo to Done in Kedro VS Code Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX Improved UX include performance, hotreload
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants