-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence errors when not on a Kedro project #77
Comments
^ Possible, right now the server initialised when someone click on a Python or YAML server I think. There maybe a more generic pattern we can use to avoid these signals. It's likely there are limitations as this is controlled by VSCode and we cannot write arbitrary code. We can stop throwing the error but we need to know think about how does user actually know the server is not working otherwise. |
@noklam replying to comment on #137 here - I think for MVP you just need to do something on the VS Cod command palette - probably both " ![]() |
I want to reiterate I think there is a substantial risks users uninstall the extension because it's noisy and distracts you when you're working on something else. I've been working in FastAPI for the last week and I close the pop up every time I open the IDE. |
Just confirming my understanding - those warnings are now showing up everytime you open a new VSCode, it should stops showing up once you get the pop up as it will automatically stop restarting the server after a few retry. Would people be bother to run a command and disable The alternative is it's disable by default but need a command to activate the extension (or at some point this get better so the extension can auto-discover the pyproject.toml to locate the |
I think there are two ways in mind:
|
As a first, easy step we want to silence the error. In parallel we'll open a separate issue to have a smarter way of detecting the Kedro project so that we don't even instantiate the LSP if we cannot do so. |
Completed in: #154 |
I get these errors when not on a Kedro project, which are mildly annoying. Not a big deal but wondering if we could make it more subtle.
Or, say, make them visible when we know it's a Kedro project but it seems to be broken for some reason.
The text was updated successfully, but these errors were encountered: