Silence errors when not on a Kedro project #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
noklam
reviewed
Nov 21, 2024
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
jitu5
reviewed
Nov 21, 2024
jitu5
reviewed
Nov 21, 2024
jitu5
approved these changes
Nov 21, 2024
noklam
approved these changes
Nov 22, 2024
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
SajidAlamQB
deleted the
bugfix/Silence-vscode-errors-when-not-on-a-Kedro-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #77
Uers were experiencing error messages from the Kedro VSCode extension when working in non-Kedro projects. These errors were causing annoyance and could potentially lead users to uninstall the extension due to the unnecessary noise.
Development Notes:
Introduced a check in the activate function within
extension.tsto determine if the current workspace is a Kedro project.The check looks for a
pyproject.tomlfile containing the[tool.kedro]section.If the workspace is not a Kedro project, the extension will not activate.
Added
isKedroProjectfunction from inutilitiesto perform the project detection logic.