Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add check_error_condition function to engine #229

Closed
b-j-roberts opened this issue Sep 24, 2024 · 7 comments
Closed

[feat] Add check_error_condition function to engine #229

b-j-roberts opened this issue Sep 24, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@b-j-roberts
Copy link
Contributor

After a script executes with the Shinigami script engine, there are various checks that need to be made to ensure the script was successful.

BTCD implemented these inside a CheckErrorCondition function. We will need a similar function in our engine to ensure the Bitcoin transaction is valid.

Resources

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 24, 2024

I would love to take this issue @b-j-roberts

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@Iwueseiter
Copy link
Contributor

Hi @b-j-roberts can I work on this?

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Iwueseiter!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@manlikeHB
Copy link
Contributor

@b-j-roberts, i would like to work on this.

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @manlikeHB!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@b-j-roberts
Copy link
Contributor Author

I'll assign you @Jemiiah , please lmk asap if you have any questions!

This was referenced Sep 30, 2024
@b-j-roberts b-j-roberts added the enhancement New feature or request label Oct 4, 2024
b-j-roberts added a commit that referenced this issue Oct 8, 2024
<!-- enter the gh issue after hash -->

- [✅] issue #229 
- [✅] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)
- [ ] code change includes tests

<!-- PR description below -->

---------

Co-authored-by: Brandon Roberts <brandonjroberts22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants