Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl check_error_condition #241

Merged
merged 5 commits into from
Oct 8, 2024
Merged

impl check_error_condition #241

merged 5 commits into from
Oct 8, 2024

Conversation

Jemiiah
Copy link
Contributor

@Jemiiah Jemiiah commented Oct 2, 2024

@Jemiiah Jemiiah requested a review from b-j-roberts as a code owner October 2, 2024 00:02
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024

@Jemiiah is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@Jemiiah Jemiiah changed the title feat: impl check_error_condition impl check_error_condition Oct 2, 2024
@b-j-roberts
Copy link
Contributor

@Jemiiah Any update on this? Seems the changes you made in your other PR are gone

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Oct 7, 2024

Hello ser sorry for the late reply will work on it asap

@Jemiiah
Copy link
Contributor Author

Jemiiah commented Oct 7, 2024 •
edited
Loading

update ser @b-j-roberts

@b-j-roberts
Copy link
Contributor

I'm getting a ton of failed tests after using scarb test on this change

b-j-roberts
b-j-roberts approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and cleaned up those failing tests, because I wanted to have this change merged for a refactor I am working on. Thank you!

@b-j-roberts b-j-roberts merged commit 059d098 into keep-starknet-strange:main Oct 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jemiiah @b-j-roberts