Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance interface by making search box always visible #15

Closed
t4777sd opened this issue Oct 3, 2016 · 3 comments · Fixed by #67
Closed

Enhance interface by making search box always visible #15

t4777sd opened this issue Oct 3, 2016 · 3 comments · Fixed by #67
Assignees
@droidmonkey
Labels
high priority 🚨 user interface
Milestone
v2.1.0

Comments

@t4777sd
Copy link

t4777sd commented Oct 3, 2016

Search box is NOT visible by default. Searching passwords is probably the most common task in keepassx. Why does it require an extra click to toggle the search? That is likely one of the most used interface features and it is hidden by default which creates unnecessary friction to use one of the most used aspects of the software.
droidmonkey added a commit that referenced this issue Oct 14, 2016
@droidmonkey
Rev 1 of search bar always visible #15
b5fb810
@droidmonkey
Copy link
Member

droidmonkey commented Oct 14, 2016 •
edited
Loading

I have completed my first revision of this feature request. I added the ability to hit ESCAPE to cancel the search. When the search box is cleared that also cancels the search. Searches now transcend between databases.

feature/search-viz-#15

Things still left to sort out:

  • Fix gui tests to use new search dialog
  • Define desired behavior when moving between databases
  • Create context menu for search button to select search options
  • Implement a global search (will take a lot of work/out of scope)

@droidmonkey droidmonkey added this to the v2.1.0 milestone Oct 14, 2016
@droidmonkey droidmonkey self-assigned this Oct 14, 2016
@TheZ3ro
Copy link
Contributor

TheZ3ro commented Oct 14, 2016

Just a reminder, the build for that branch on Travis-CI failed https://travis-ci.org/keepassxreboot/keepassx/builds/167536280

@droidmonkey
Copy link
Member

Yah that is bullet point one above. The GUI tests fail since the search box moved.

droidmonkey referenced this issue Oct 20, 2016
@droidmonkey
Merge 'origin/develop' into feature/search-viz-#15
31136ad
droidmonkey added a commit that referenced this issue Oct 20, 2016
@droidmonkey
Rev 1 of search bar always visible #15
2c5caeb
droidmonkey added a commit that referenced this issue Oct 24, 2016
@droidmonkey
Rev 1 of search bar always visible #15
4e7eba1
droidmonkey added a commit that referenced this issue Oct 29, 2016
@droidmonkey
Rev 1 of search bar always visible #15
46dc39c
@droidmonkey droidmonkey mentioned this issue Oct 29, 2016
Merged
droidmonkey referenced this issue Oct 30, 2016
@droidmonkey
Merge remote-tracking branch 'origin/feature/search-viz-#15' into fea…
8945ee7 
…ture/merge-db-#22

* Reframed gui test case for merging based on fixed tests
* Removed considerations for dbwidget search during merge with new search feature
@thomaspasser thomaspasser mentioned this issue Jan 18, 2018
Closed
@ajaeger ajaeger mentioned this issue Apr 24, 2018
Closed
@phoerious phoerious mentioned this issue Feb 6, 2021
Closed
@Germano0 Germano0 mentioned this issue Dec 15, 2021
Closed
@tlcarpenter tlcarpenter mentioned this issue Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
high priority 🚨 user interface
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Make search always visible (#15) keepassxreboot/keepassxc
3 participants
@TheZ3ro @droidmonkey @t4777sd