Make search always visible (#15) #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All gui tests are run on an unaltered starter database * All gui tests are self contained * Removed clearing of Search Widget text when hiding
* Searches are saved between databases * Search is cleared when all databases are closed * Implemented case sensitive and group searching
|
Requesting a review from another project maintainer. |
|
Works great, but could you please (re)add a keyboard shortcut to focus the search field? |
|
Added global shortcut and a simple notification banner when the database is in search mode. |
|
Just a note before I approve the changes. Should be good make the |
|
Perhaps reliable it "Search Results"? |
|
I think it will be ok, but if no result is found relabel it to "No result" or something like that. |
|
I'm going to fix the label and merge this in tonight. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the search bar from the database entry view to the toolbar. It is always visible and capable of making searches without an extra button click. The search options were moved into a drop down list on the search icon button. Pressing escape while focused on the search text clears the search. Closes #15.
Moving the search out of the database widget required some replumbing work in the way searches are conducted.
I also enabled the use of QT keywords like "emit", "slots", etc which make the code easier to read.
Motivation and Context
This was requested by the community and it also cleans up the UI significantly.
How Has This Been Tested?
The testgui.cpp file was completely retooled to accomplish the following:
Screenshots (if appropriate):
Types of changes
Checklist: