Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbing into notes on Entry Edit is broken #4852

Closed
droidmonkey opened this issue Jun 13, 2020 · 4 comments · Fixed by #5424
Closed

Tabbing into notes on Entry Edit is broken #4852

droidmonkey opened this issue Jun 13, 2020 · 4 comments · Fixed by #5424
Assignees
@droidmonkey
Labels
bug user interface
Milestone
v2.7.0

Comments

@droidmonkey
Copy link
Member

Overview

Tab sequencing for editing an entry is slightly broken. Cannot tab into the notes field.
@droidmonkey droidmonkey added this to the v2.6.0 milestone Jun 13, 2020
@droidmonkey droidmonkey self-assigned this Jun 13, 2020
@phoerious
Copy link
Member

I noticed that too. But it has the correct tab order. Not sure what's going on there.

@droidmonkey
Copy link
Member Author

droidmonkey commented Jun 18, 2020 •
edited
Loading

I can't get it to work, very strange. When I Shift+Tab from the title text edit it goes to notes. Tabbing from the show notes checkbox goes to the OK button.

@droidmonkey droidmonkey modified the milestones: v2.6.0, v2.6.1 Jun 18, 2020
@phoerious
Copy link
Member

Yeah, me neither. I tried to fix it, but failed. Random idea: what's the focus behaviour of the field? Is it click-only perhaps?

@droidmonkey
Copy link
Member Author

No it's set to strong. Tab focus changing is so broken

@droidmonkey droidmonkey modified the milestones: v2.6.1, v2.7.0 Aug 21, 2020
@droidmonkey droidmonkey mentioned this issue Sep 13, 2020
Closed
droidmonkey added a commit that referenced this issue Sep 13, 2020
@droidmonkey
Fix layout and alignment of Entry and Group edit views
22ca813 
* Fixes #5321 - Text alignment in the general tab of the entry and group edit views is fixed
* Fixes #5300 - Errant scrollbar in the general tab is fixed
* Fixes #4852 - Tabbing into notes field works as expected. To tab out, currently only Shift+Tab works.
@droidmonkey droidmonkey mentioned this issue Sep 13, 2020
Merged
@droidmonkey droidmonkey linked a pull request Sep 13, 2020 that will close this issue
Fix layout and alignment of Entry and Group edit views #5424
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
bug user interface
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

Fix layout and alignment of Entry and Group edit views keepassxreboot/keepassxc
2 participants
@phoerious @droidmonkey