Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar shows up in middle of edit/details screens #5300

Closed
gaelanlloyd opened this issue Aug 20, 2020 · 18 comments · Fixed by #5424
Closed

Scrollbar shows up in middle of edit/details screens #5300

gaelanlloyd opened this issue Aug 20, 2020 · 18 comments · Fixed by #5424
Assignees
Milestone

Comments

@gaelanlloyd
Copy link

keepass-details-scrollbar-issue

Overview

I just upgraded from 2.5.4 to 2.6.1 today and I'm seeing vertical scrollbars floating over the middle of the edit panel.

Steps to Reproduce

Whenever I edit a folder, or the first time I edit a particular password's entry. If I open the same password entry it doesn't happen, but it always happens when editing a folder's entry.

Expected Behavior

Scrollbar shouldn't be floating in the middle of the window.

My system info

KeePassXC - Version 2.6.1
Revision: 9a35bba

Qt 5.15.0
Debugging mode is disabled.

Operating system: Windows 10 Version 1909
CPU architecture: x86_64
Kernel: winnt 10.0.18363

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Cryptographic libraries:
libgcrypt 1.8.5

Let me know if there's anything else I can provide to help debug this issue.

@th3m
Copy link

th3m commented Aug 20, 2020

Got the same bug, no extensions enabled, Win10 64 bit.
"Maximize" or "Restore down" the application temporary fixes the visual bug.

@droidmonkey
Copy link
Member

Are you using the portable apps download?

@gaelanlloyd
Copy link
Author

No, the Windows 64-bit MSI installer.

@jnqnfe
Copy link

jnqnfe commented Aug 20, 2020

Affects Linux also. I reported it for Debian on Sunday with v2.6.0 as bug #968542. I've just received the v2.6.1 update and it's still there. Qt version here is 5.14.2.

@droidmonkey
Copy link
Member

I've debugged this before and there is no obvious reason why its visible.

@Protonator
Copy link

Protonator commented Aug 22, 2020

Got this, too. It seems to be limited to entries with an empty notes field, though – or one which got less than two lines of text in it. But: As soon as I minimize KeePassXC or the program loses focus, the scroll bar appears again even when there are certain lines of text in the notes field.

@florealcab
Copy link

I just installed it and I noticed ce same bug on Ubuntu 20.04 with KDE as desktop environment

@droidmonkey
Copy link
Member

droidmonkey commented Aug 22, 2020

Does the scrollbar show up when using one of our themes (ie, NOT classic mode)? If it does NOT show up then this would be a Qt theming bug.

@florealcab
Copy link

I tested with the default theme (Automatic). Then, after your comment I tested with dark and classic modes. But now I don't notice the bug anymore, even if I switch back to automatic again. I change some settings after my previous comment, may be it's why... If the problem appears again I'll comment again...

@jnqnfe
Copy link

jnqnfe commented Aug 22, 2020

I do not concur with it being related in some way to number of lines in 'notes'. I went through one folder of entries in mine with a lot of variations in number of lines of notes to check this theory and found no such clear pattern. I did find that it was not shown for all entries though (I could find no pattern for why).

Interestingly, while for most entries in this folder it is consistently shown or not, there is one entry which I found to be variable, sometimes showing it and sometimes not. If you repeatedly open it and close it, it is consistent, but clicking around opening other entries in the folder and coming back to it can change whether it shows up for that one entry or not. Again, I could not determine any particular repeatable pattern for this.


Before trying changing the theme I thought I'd play with some other things first...

I just tried closing the program, clearing the [GUI] portion of the ~/.cache/keepassxc/keepassxc.ini file and reopening. This has not cleared the problem, though it has seemed to settle down that one variable entry discussed above into consistently not showing it (I can no longer seem to be able to jump about between entries and cause different behaviour for that variable entry).

Another detail I've noticed is toggling the 'notes' checkbox to off (unchecked) temporarily removes the portion of the scrollbar that overlapped it until you close the entry and re-enter edit mode.

Very interestingly, I notice that both the vertical size and vertical position of the scrollbar (roughly - comparing with my fingers) match that of the of the password generator dialog content (ignoring the title bar)!! (when the 'advanced' mode is off; enabling advanced mode does not increase the scrollbar height).

It also roughly matches the file list control in the open file dialog (and the import dialogs, save-database as, etc). And the form in the 'new database' dialog.

Also, I just opened an entry, no scrollbar shown, I opened and closed the password generator, and suddenly it was there.

For another thing, I just tried expanding the width of the window a little, and now this again messes with whether or not it shows, with at least one other entry being variable.

With an entry already opened for editing, with the scrollbar shown, I changed the vertical height of the window and it disappeared. I switched focus to my web browser to type this, switched back and it was back again. Similarly, if you get rid of it by changing the height, then temporarily switching from basic 'entry' details to 'advanced', 'icon', 'auto-type', or 'properties' tabs (for which it's not shown), then switch back to 'entry', it reappears.

The height seems consistent between editing groups (as in the report here) and in editing entries, as I reported and have been playing with here. The behaviour seems identical, for example only appearing on the 'group' group-edit tab, not the others ('icon', 'keeshare', 'properties'); disappearing when changing window height temporarily, etc.

I'd like to look at the actual code to help get to the bottom of it properly, but I'm not sure I have the time for that. Hope some of these details help.

@jnqnfe
Copy link

jnqnfe commented Aug 22, 2020

As for switching themes... Switching to light/dark made no difference. Switching to classic mode did get rid of it. Switching back to automatic, it's returned.

@gaelanlloyd
Copy link
Author

I have 3 Windows 10 computers and they all show this issue. I'm running with Compact Mode and Classic view.

@gaelanlloyd
Copy link
Author

Something interesting: When I open an entry, the scrollbar sometimes isn't there. But if I leave the entry details window open and switch window focus to another window, the scrollbar shows up.

@woowoo803
Copy link

Also seeing this on a Windows 7 machine with 2.6.1 MSI installer 64 bit, typically running normal view (not compact) and Auto theme. In my case it happens every time on every entry. Tried switching themes and Auto/light/dark have a thin bar, while Classic has a wide bar. The bar is always there in all themes, but only in the Edit-Entry screen, not in the Advanced, Icon, etc. Normally the bar just cuts into the Notes field, but if I go to one of the other Edit screens and return to Entry then the bar is longer, about 1/2 way down the notes field. If I cancel the edit and return to Edit the bar is shorter again.

@PoolJK
Copy link

PoolJK commented Aug 27, 2020

Happens also on MacOs (Catalina).

@ghost ghost mentioned this issue Aug 27, 2020
@CYBRPVNK
Copy link

I am having the same problem. I noticed that resizing the window temporarily fix it for current entry.

@turbosmurfen
Copy link

I have never seen this before, And I have not added a new entry since I downloaded portable 2.6.1. Now when adding new entry it show up a scrollbar in the middle. I have tried to resize the window and the scrollbar disappear from the new entry settings. But if I add a new entry it's back. So yes I have the same problem. I'm using Windows 10 2004 x64.

@keepassxreboot keepassxreboot locked and limited conversation to collaborators Aug 31, 2020
@droidmonkey
Copy link
Member

Locking issue, we have enough information, but none of the devs can replicate the problem in order to debug and correct it.

@droidmonkey droidmonkey added this to the v2.6.2 milestone Aug 31, 2020
@droidmonkey droidmonkey self-assigned this Aug 31, 2020
droidmonkey added a commit that referenced this issue Sep 13, 2020
* Fixes #5321 - Text alignment in the general tab of the entry and group edit views is fixed
* Fixes #5300 - Errant scrollbar in the general tab is fixed
* Fixes #4852 - Tabbing into notes field works as expected. To tab out, currently only Shift+Tab works.
@droidmonkey droidmonkey linked a pull request Sep 13, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants