Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{#} doesn't allow to use hash in Auto-Type sequence #7743

Closed
abourree opened this issue Mar 31, 2022 · 1 comment · Fixed by #7629
Closed

{#} doesn't allow to use hash in Auto-Type sequence #7743

abourree opened this issue Mar 31, 2022 · 1 comment · Fixed by #7629
Assignees
@droidmonkey
Labels
bug feature: Auto-Type
Milestone
v2.7.1

Comments

@abourree
Copy link

Overview

Workaround proposed in #7733 doesn't work

Steps to Reproduce

  1. I edit one entry with JDOE as user name and select 'Auto-Type'
  2. I crete a new association for window '* - Notepad' with the specific sequence '{USERNAME}{#}{USERNAME}'
  3. I open Notepad and press my Auto-Type shortcut

Expected Behavior

JDOE#JDOE

Actual Behavior

At step 2, when saving entry, KeepassXC complains that variable doesn't exist
When forcing save with {#}, step failed with same complain

Context

KeePassXC - 2.7.0
Revision: d7a9ef4

Operating System: Windows 10
@abourree abourree added the bug label Mar 31, 2022
@droidmonkey
Copy link
Member

Whoops need to add it to this list https://github.com/keepassxreboot/keepassxc/blob/develop/src/autotype/AutoType.cpp#L87

@droidmonkey droidmonkey self-assigned this Mar 31, 2022
@droidmonkey droidmonkey added this to the v2.7.1 milestone Mar 31, 2022
droidmonkey added a commit that referenced this issue Mar 31, 2022
@droidmonkey
Fix Auto-Typing single character placeholders
91ebc7b 
* Fix #7743 - Include # in placeholder list
* This change fixes typing single character placeholders (escaped placeholders) on Windows. Previously we were sending these as raw key presses which didn't properly press Shift or other modifiers. Now they are sent as unicode characters unless in virtual mode (the expected behavior).
@droidmonkey droidmonkey mentioned this issue Mar 31, 2022
Merged
droidmonkey added a commit that referenced this issue Apr 2, 2022
@droidmonkey
Fix Auto-Typing single character placeholders
097be1a 
* Fix #7743 - Include # in placeholder list
* This change fixes typing single character placeholders (escaped placeholders) on Windows. Previously we were sending these as raw key presses which didn't properly press Shift or other modifiers. Now they are sent as unicode characters unless in virtual mode (the expected behavior).
pull bot pushed a commit to nonomal/keepassxc that referenced this issue Apr 2, 2022
@droidmonkey @pull
Fix Auto-Typing single character placeholders
a839b71 
* Fix keepassxreboot#7743 - Include # in placeholder list
* This change fixes typing single character placeholders (escaped placeholders) on Windows. Previously we were sending these as raw key presses which didn't properly press Shift or other modifiers. Now they are sent as unicode characters unless in virtual mode (the expected behavior).
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
@droidmonkey @t-h-e
Fix Auto-Typing single character placeholders
8cf0f7a 
* Fix keepassxreboot#7743 - Include # in placeholder list
* This change fixes typing single character placeholders (escaped placeholders) on Windows. Previously we were sending these as raw key presses which didn't properly press Shift or other modifiers. Now they are sent as unicode characters unless in virtual mode (the expected behavior).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
bug feature: Auto-Type
Projects
None yet
Milestone
v2.7.1
Development

Successfully merging a pull request may close this issue.

Fix Auto-Type modifiers on Windows keepassxreboot/keepassxc
2 participants
@abourree @droidmonkey