Fix Auto-Type modifiers on Windows

[droidmonkey]

Also add documentation on modifiers.

• Fix Auto-Type: modifier for WIN key not working #7626
• Fix {#} doesn't allow to use hash in Auto-Type sequence #7743

Testing strategy

Tested on Windows

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[codecov-commenter]

Codecov Report

Merging #7629 (91ebc7b) into develop (aca197a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #7629      +/-   ##
===========================================
- Coverage    64.31%   64.29%   -0.02%     
===========================================
  Files          339      339              
  Lines        43450    43454       +4     
===========================================
- Hits         27943    27937       -6     
- Misses       15507    15517      +10     

Impacted Files	Coverage Δ
src/autotype/AutoType.cpp	72.23% <100.00%> (+0.25%)	⬆️
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp	56.06% <0.00%> (-3.03%)	⬇️
src/fdosecrets/dbus/DBusMgr.cpp	52.20% <0.00%> (-1.47%)	⬇️
src/core/Entry.cpp	82.59% <0.00%> (+0.10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca197a...91ebc7b. Read the comment docs.

[codonell]

@droidmonkey Why are the existing ASCII sequences used for special charaters? This change in backwards incompatible with all existing auto-type sequences that might have +, ^, % and #, and indeed this breaks a significant number of my auto-type sequences.

[droidmonkey]

Take that up with keepass, they chose this syntax not us.

[codonell]

Take that up with keepass, they chose this syntax not us.

As a career implementer of POSIX and ISO C interfaces, I can certainly understand the "Because the standardizing organization said it was this way", thank you for answering my question. I see that "@" is the Windows Key (as modifier) (https://keepass.info/help/base/autotype.html) where is the specification for "#" to be used as Win/Cmd? I'm just trying to write a cleanup pass to export, process, and import my auto-type entries.

[droidmonkey]

@ is only defined for keepass 1.x. We chose # for keepassxc to provide that capability since @ is way more common to be used in a sequence as a character and not a modifier.

[codonell]

@ is only defined for keepass 1.x. We chose # for keepassxc to provide that capability since @ is way more common to be used in a sequence as a character and not a modifier.

Certainly, if you used @ it would break emails in auto-type sequences and require escaping, which is why I assume Keepass 2.x deprecated @ usage in auto-type, and switched to recommending VKEY.

Does the choice of # (special meaning for standard ASCII character) for keepassxc cause compatibility problems between keepass and keepassxc when it comes to sharing auto-type sequences?

How can # be used for @? Is # a single-key modifier? Are {VKEY 91 D}e{VKEY 91 U} and #e equivalent now?

So if I have #e in my keepass auto-type and I migrate it to keepassxc it will not be interpreted the same?

Is it possible to remove # from the special characters to avoid this incompatibility with upstream keepass?

[droidmonkey]

We don't support the VKEY syntax, and no we aren't going to revert this feature. You should almost never Auto-Type raw characters, placeholders don't apply the modifier logic.

If you define a sequence using # to hold down the win key in keepassxc, you can easily define a second sequence that uses VKEY in keepass.

#e => WIN+E
{#}e => #e
@e => @e