Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry Preview: Notes height is truncated (2.7.1) #7811

Closed
archetyped opened this issue Apr 6, 2022 · 2 comments · Fixed by #7993
Closed

Entry Preview: Notes height is truncated (2.7.1) #7811

archetyped opened this issue Apr 6, 2022 · 2 comments · Fixed by #7993
Assignees
@droidmonkey
Labels
bug user interface

Comments

@archetyped
Copy link

Overview

The height of the notes field preview has been truncated in 2.7.1.

In v2.6, the height of the notes field preview expanded to use all available height in the preview pane.

Steps to Reproduce

  1. Install KeePassXC 2.7.1
  2. View entry preview containing long note

Expected Behavior

Note preview height should use all available space in preview pane.

Example (v2.6.6)

KPXC_Issue_Preview_Notes-Height_2 6 6

Actual Behavior

Note preview height is fixed and longer notes display scrollbars.

Example (v2.7.1)

KPXC_Issue_Preview_Notes-Height_2 7 1

Context

KeePassXC - Version 2.7.1
Revision: 5916a8f
Operating System: macOS 12.3
@archetyped archetyped added the bug label Apr 6, 2022
@droidmonkey
Copy link
Member

Omg I hate qt layouts

@droidmonkey droidmonkey changed the title Bug: Entry Preview: Notes height is truncated (2.7.1) Entry Preview: Notes height is truncated (2.7.1) Apr 6, 2022
@phoerious
Copy link
Member

Didn't realise people were using KeePassXC as an ebook reader. 😂

@droidmonkey droidmonkey self-assigned this Apr 6, 2022
droidmonkey added a commit that referenced this issue May 1, 2022
@droidmonkey
Improve entry preview panel
b272c08 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
@droidmonkey droidmonkey mentioned this issue May 1, 2022
Merged
droidmonkey added a commit that referenced this issue May 1, 2022
@droidmonkey
Improve entry preview panel
d575cea 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue May 31, 2022
@droidmonkey
Improve entry preview panel
e72c601 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue Jun 6, 2022
@droidmonkey
Improve entry preview panel
b1f4e12 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue Jun 27, 2022
@droidmonkey
Improve entry preview panel
af2ceb6 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
t-h-e pushed a commit to t-h-e/keepassxc that referenced this issue Sep 8, 2022
@droidmonkey @t-h-e
Improve entry preview panel
cc01a7d 
* Fix keepassxreboot#7811 - Notes height no longer truncated
* Fix keepassxreboot#7949 - Improve copying attribute value to clipboard in entry preview
* Fix keepassxreboot#7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix keepassxreboot#7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey added a commit that referenced this issue Sep 22, 2022
@droidmonkey
Improve entry preview panel
8190b20 
* Fix #7811 - Notes height no longer truncated
* Fix #7949 - Improve copying attribute value to clipboard in entry preview
* Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane
* Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
bug user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve entry preview panel keepassxreboot/keepassxc
3 participants
@phoerious @droidmonkey @archetyped