Improve entry preview panel #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
bug
user interface
pr:backport pending
droidmonkey
force-pushed
the
fix/entry-preview
branch
from
b272c08
to
d575cea
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7993 +/- ##
========================================
Coverage 64.29% 64.29%
========================================
Files 339 339
Lines 43450 43455 +5
========================================
+ Hits 27933 27938 +5
Misses 15517 15517
Continue to review full report at Codecov.
|
* Fix #7811 - Notes height no longer truncated * Fix #7949 - Improve copying attribute value to clipboard in entry preview * Fix #7898 - Prevent copying url when copy password selected after clicking url in preview pane * Fix #7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●
droidmonkey
force-pushed
the
fix/entry-preview
branch
from
d575cea
to
e72c601
Compare
|
At least on MacOS the menu item "View -> Show Preview Panel" always has text "Show Preview Panel" without any indication if it's enabled or not. Same applies to all other settings in the menu. Should the text change between Hide/Show when switching the option on/off? |
phoerious
reviewed
Jun 5, 2022
phoerious
approved these changes
Jun 6, 2022
droidmonkey
added
pr:backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
●●●●●●#7982 - Double clicking hidden attributes in preview pane copies the value instead of ●●●●●●Screenshots
Testing strategy
Tested manually
Type of change