Do not delete MacPasteboard instance on exit, resolves #1543 #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
force-pushed
the
hotfix/1543-macos-exit-crash
branch
from
c1dcd76
to
8bbb0cc
Compare
weslly
approved these changes
Mar 2, 2018
phoerious
added a commit
that referenced
this pull request
Mar 6, 2018
- Fix unnecessary automatic upgrade to KDBX 4.0 and prevent challenge-response key being stripped [#1568] - Abort saving and show an error message when challenge-response fails [#1659] - Support inner stream protection on all string attributes [#1646] - Fix favicon downloads not finishing on some websites [#1657] - Fix freeze due to invalid STDIN data [#1628] - Correct issue with encrypted RSA SSH keys [#1587] - Fix crash on macOS due to QTBUG-54832 [#1607] - Show error message if ssh-agent communication fails [#1614] - Fix --pw-stdin and filename parameters being ignored [#1608] - Fix Auto-Type syntax check not allowing spaces and special characters [#1626] - Fix reference placeholders in combination with Auto-Type [#1649] - Fix qtbase translations not being loaded [#1611] - Fix startup crash on Windows due to missing SVG libraries [#1662] - Correct database tab order regression [#1610] - Fix GCC 8 compilation error [#1612] - Fix copying of advanced attributes on KDE [#1640] - Fix member initialization of CategoryListWidgetDelegate [#1613] - Fix inconsistent toolbar icon sizes and provide higher-quality icons [#1616] - Improve preview panel geometry [#1609]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes deletion of the MacPasteboard instance on exit, working around a crash due to a Qt bug. Resolves #1543.
Regression was introduced in 806248e
Motivation and context
QMacPasteboardMime subclasses are registered and de-registered using ctors/dtors, but after deleting an instance, Qt keeps a dangling pointer, which it tries to delete again on program exit (https://bugreports.qt.io/browse/QTBUG-54832).
Since our MacPasteboard instance lives for the whole program duration, anyway, it's no big loss to simply not delete it and let Qt or, at the latest, the OS take care of it.
How has this been tested?
KeePassXC doesn't crash anymore when opening and locking a database and then exiting the program with Cmd+Q.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]