Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize details widget to minimum by default #1609

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

phoerious
Copy link
Member

Description

Resizes the details widget to its minimum size when no saved UI state is available.

Motivation and context

Upon first start of KeePassXC, the details widget used to gobble up some 30 or 50% of the vertical screen space instead of just its minimum height. This patch resizes it down to its minimum size hint. If a saved UI state is available (i.e., if this is not the first start), it will override the size with whatever size the user has resized the widget to.

How has this been tested?

Manually on Windows by deleting the config file.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@phoerious phoerious added this to the 2.3.1 milestone Mar 3, 2018
@phoerious phoerious requested a review from a team March 3, 2018 01:31
@phoerious phoerious force-pushed the hotfix/details-widget-minsize branch from 43eaceb to 86dd785 Compare March 3, 2018 01:36
@phoerious phoerious force-pushed the hotfix/details-widget-minsize branch from 86dd785 to bfeaa58 Compare March 3, 2018 09:39
@phoerious phoerious merged commit a5dc196 into release/2.3.1 Mar 3, 2018
@phoerious phoerious deleted the hotfix/details-widget-minsize branch March 3, 2018 11:59
phoerious added a commit that referenced this pull request Mar 6, 2018
- Fix unnecessary automatic upgrade to KDBX 4.0 and prevent challenge-response key being stripped [#1568]
- Abort saving and show an error message when challenge-response fails [#1659]
- Support inner stream protection on all string attributes [#1646]
- Fix favicon downloads not finishing on some websites [#1657]
- Fix freeze due to invalid STDIN data [#1628]
- Correct issue with encrypted RSA SSH keys [#1587]
- Fix crash on macOS due to QTBUG-54832 [#1607]
- Show error message if ssh-agent communication fails [#1614]
- Fix --pw-stdin and filename parameters being ignored [#1608]
- Fix Auto-Type syntax check not allowing spaces and special characters [#1626]
- Fix reference placeholders in combination with Auto-Type [#1649]
- Fix qtbase translations not being loaded [#1611]
- Fix startup crash on Windows due to missing SVG libraries [#1662]
- Correct database tab order regression [#1610]
- Fix GCC 8 compilation error [#1612]
- Fix copying of advanced attributes on KDE [#1640]
- Fix member initialization of CategoryListWidgetDelegate [#1613]
- Fix inconsistent toolbar icon sizes and provide higher-quality icons [#1616]
- Improve preview panel geometry [#1609]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants