-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various minor fixes for 2.4.0 #2667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
changed the title
Various Build Fixes for 2.4.0
Various minor fixes for 2.4.0
Feb 2, 2019
droidmonkey
force-pushed
the
fix/windows-build
branch
from
February 2, 2019 02:03
52365ec
to
c2f35d7
Compare
phoerious
reviewed
Feb 4, 2019
I updated the file icon, reposted screenshot |
droidmonkey
force-pushed
the
fix/windows-build
branch
from
February 4, 2019 19:52
543d3e6
to
89990e1
Compare
This works as expected. |
phoerious
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps pngcrush the PNGs and minify the SVG sources. Rest looks good.
* Eliminated multiple state variables * Fix #1643, window is brought to front
* otp setting is properly loaded and saved (Fix #2671) * Removing the key from TOTP Setup clears all TOTP settings for entry * Santize TOTP key prior to storing in OTP format
* Tweaked share/icons/svg/application-x-keepassxc.svg for better scaling * Added ico build script for Windows
* Shrank large SVG's using Inkscape 'Optimized SVG' * Added pngcrush script to 'make icons' * Ran 'make icons'
droidmonkey
force-pushed
the
fix/windows-build
branch
from
February 5, 2019 17:19
89990e1
to
d6439af
Compare
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
an icon (locked database icon)
to support https connections
Optimized all icons and tweaked 'make icons' commands
If you remove the key from TOTP setup then it will remove all TOTP settings from the entry's attributes.
Screenshots
Testing strategy
Tested using MSI installer manually
Checklist:
-DWITH_ASAN=ON
. [REQUIRED]