Prevent unnecessary merge requests on intermittent network shares #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
approved these changes
Jan 11, 2020
phoerious
added a commit
that referenced
this pull request
Jan 19, 2020
Fixed - Fix a possible database lockout when removing a YubiKey from a KDBX 3.1 database [#4147] - Fix crash if Auto-Type is performed on a new entry [#4150] - Fix crash when all entries are deleted from a group [#4156] - Improve the reliability of clipboard clearing on Gnome [#4165] - Do not check cmd:// URLs for valid URL syntax anymore [#4172] - Prevent unnecessary merges for databases on network shares [#4153] - Browser: Prevent native messaging proxy from blocking application shutdown [#4155] - Browser: Improve website URL matching [#4134, #4177] Added - Browser: Enable support for Chromium-based Edge Browser [#3359]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
Testing strategy
Tested by disabling the file watcher and renaming the database file so it cannot be opened by the hashing routine. Upon renaming back to normal no merge request was provided.
Checklist:
-DWITH_ASAN=ON. [REQUIRED]