Prevent crash when all entries are deleted from a group #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
approved these changes
Jan 11, 2020
|
Is it possible to add these tests as actual tests? |
|
Yea I can add a gui test that checks the behavior |
* Fix #4093 - The first entry in the list is selected after deleting an entry * Prevents crashes due to dangling pointers held by the Entry Preview Widget when entries were deleted. * Improve GUI tests to ensure this new behavior occurs.
droidmonkey
force-pushed
the
hotfix/empty-group-crash
branch
from
f2fb165 to
f8c1d4b
Compare
|
GUI tests updated! |
phoerious
added a commit
that referenced
this pull request
Jan 19, 2020
Fixed - Fix a possible database lockout when removing a YubiKey from a KDBX 3.1 database [#4147] - Fix crash if Auto-Type is performed on a new entry [#4150] - Fix crash when all entries are deleted from a group [#4156] - Improve the reliability of clipboard clearing on Gnome [#4165] - Do not check cmd:// URLs for valid URL syntax anymore [#4172] - Prevent unnecessary merges for databases on network shares [#4153] - Browser: Prevent native messaging proxy from blocking application shutdown [#4155] - Browser: Improve website URL matching [#4134, #4177] Added - Browser: Enable support for Chromium-based Edge Browser [#3359]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
Testing strategy
Tested numerous permutations of entries and deleting them. Added two fail checks (one in EntryPreviewWidget, one in DatabaseWidget).
Checklist:
-DWITH_ASAN=ON. [REQUIRED]