-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous Browser Access Request dialog #8273
Asynchronous Browser Access Request dialog #8273
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #8273 +/- ##
===========================================
+ Coverage 64.43% 64.44% +0.01%
===========================================
Files 339 339
Lines 43744 43953 +209
===========================================
+ Hits 28184 28324 +140
- Misses 15560 15629 +69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What happens when another selection request is triggered with an existing selection dialog still visible? Do we show another one or reject the current and show a new? Could we cause a situation where you could spam access request dialogs being opened? |
The new request is rejected. It's expected that user responds to the one that's already active. |
browserService()->findEntries(socket, | ||
incrementedNonce, | ||
m_clientPublicKey, | ||
m_secretKey, | ||
id, | ||
hash, | ||
requestId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: we might want to create a general "Request Struct" that has all this info baked into it and we can pass around to various functions that know what to do with the elements. Would reduce the variable jumble.
4355ca5
to
e2899bd
Compare
Modifies the Access Control Dialog to work asynchronously, similar to the new Password Generator popup. The old/current implementation can break message sync between KeePassXC and the extension if another request for the dialog is retrieved. This can be only fixed when database is locked and reopened, which is not very user friendly.
This PR fixes the following issues:
Fixes #5765.
Testing strategy
Manually. Needs keepassxreboot/keepassxc-browser#1684 for testing.
Type of change