Fix extra hideWindow() call after retrieving credentials #8647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
added
bug
pr: backport pending
droidmonkey
approved these changes
Oct 25, 2022
|
Which PR introduced this behavior? |
|
No longer needed. |
droidmonkey
removed
bug
pr: backport pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least with macOS this extra call sometimes causes the actual browser window to hide instead of KeePassXC after the extension has retrieved the credentials. If the Access Confirm Dialog has been already shown,
hideWindow()is already called earlier.PR with the incorrect change: #8273
This is easy to reproduce with the following steps:
Testing strategy
Manually.
Type of change