Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for duplicate URLs with Additional URLs list #9588

Merged

Conversation

varjolintu
Copy link
Member

Adds a warning when a duplicate URL is inserted to Additional URLs list if the following criteria is met:

  • Added URL is identical to the entry URL
  • Added URL is already in the Additional URLs list

A new tooltip text is added for the warning. Previously a duplicate URL was changed back to <empty URL> without any warning or indication to the user that the entered URL already exists.

Fixes #7287.

Screenshots

Screenshot 2023-06-28 at 9 41 27

Testing strategy

Manually.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

src/gui/entry/EntryURLModel.cpp Outdated Show resolved Hide resolved
src/gui/entry/EntryURLModel.h Show resolved Hide resolved
@droidmonkey droidmonkey merged commit 9214ab2 into keepassxreboot:develop Jul 15, 2023
@droidmonkey
Copy link
Member

@varjolintu just noticed this doesn't provide a warning if you duplicate the main entry url.

@varjolintu varjolintu deleted the fix/duplicate_url_warning branch July 16, 2023 04:43
@varjolintu
Copy link
Member Author

varjolintu commented Jul 16, 2023

@varjolintu just noticed this doesn't provide a warning if you duplicate the main entry url.

Oh, it seems so. I'm pretty sure I tested it many times. I'll make another fix.

EDIT: Your entry URL probably had a / at the end but the additional URL didn't?

@droidmonkey
Copy link
Member

Yup that is true

libf-de pushed a commit to libf-de/keepassxc-secretservice-dbus that referenced this pull request Aug 16, 2023
Release 2.7.6

Changes
- Significant improvement to visual when drag/drop entries [keepassxreboot#9698]
- Automatically prompt for Quick Unlock when showing unlock dialog [keepassxreboot#9697]
- Improve colorful lock icon and fix file MIME icon on KDE [keepassxreboot#9632]
- Ability to search by entry UUID [keepassxreboot#9571]
- Add challenge-response support for NitroKey 3 [keepassxreboot#9631]
- Auto-Type: Disable entry level Auto-Type when disabled at group/entry [keepassxreboot#9672]
- Browser: Show warning when adding duplicate URL's to entry [keepassxreboot#9588][keepassxreboot#9635]
- Browser: Improve error message when proxy cannot be found [keepassxreboot#9385]

Fixes
- Fix crash on exit on macOS [keepassxreboot#9620]
- Fix crash on search if entry doesn't have a group [keepassxreboot#9633]
- Fix several issues with Quick Unlock [keepassxreboot#9697]
- Enable save button when not auto-saving non-data changes [keepassxreboot#9634]
- Several UI/UX fixes [keepassxreboot#9647]
- Move toolbar back to top of window when disabling movement [keepassxreboot#9699]
- Browser: Fix closing password generator dialog with X button [keepassxreboot#9636]
- Browser: Fix handling of expired credentials [keepassxreboot#9595]
- Windows: Prevent white flicker when launching application [keepassxreboot#9637]
- Linux: Fix warning message about allow screencapture [keepassxreboot#9638]
- FdoSecrets: Fix access confirmation dialog showing even when disabled [keepassxreboot#9690]

# -----BEGIN PGP SIGNATURE-----
#
# iQJIBAABCAAyFiEE6A9nU7OzJX8m9B8ILPQdKqhDj5kFAmTb/usUHGphbmVrQGtl
# ZXBhc3N4Yy5vcmcACgkQLPQdKqhDj5l9vBAAmiCQR+L3ZLVq7CfXK+yOrCr1pV1J
# H6znrRe4SC5MR/dyrx+EVbkaPI0aWtW/NWa4REB9BUxkbXKIPy/9M6smj3xkjAqX
# YuYThNneRBFns9Rb5RyAIonwEXXmYHAWG2wdRXXFOnsb/Dxy9DYZK6+Ysbj55CQJ
# RBJ1y0IKCuajLvENW9zQQ/vTX0oxCQ2F9Fz7aTqGIoxW6NMhjTso7IPvKYWPzbNj
# FBOiI4kusL32pT5u+XwSUjmBvXrIEBjETYFTVgqesItAr0dFAgEh8f0jvuy8on8K
# ukVzD02JqavkMfwtDsvUVLdVdr1PJMOu4/qDodR1xC39VOjS9LQ6dK8rb/1Q4/MR
# cAXjBhNBZ0A5yq9XtdNvl8xYqkvYa/KcFuHUFwBoinLXtKLnh4aswDqk4caNeI4O
# O40Nk5J4J6Qgs89XIsQHkXkGTaPxuISHVeFWWqcpX9kRJhtlt5eIS6nDv8nGx8iq
# q65NfCldPckgmuIxeCX2lYtxieq09jAhD1/92eXsH1aNkZce4W1UcjGE58cduODd
# oXV7VCo0JUzkMky9I9/G+hAqWwLp94D5ewYG8yX2Oz2jwcoWvZSIZ6MtR+2NiYpL
# pFSFB/yoqWQOIVc9eHqCQl7rMMK66pJWwu7boxS22/xoNTAfzMwNtp8CmbLpqIhF
# 7lPQiiC2DnqfR0E=
# =l8kk
# -----END PGP SIGNATURE-----
# gpg: directory '/home/runner/.gnupg' created
# gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
# gpg: Signature made Tue Aug 15 22:40:43 2023 UTC
# gpg:                using RSA key E80F6753B3B3257F26F41F082CF41D2AA8438F99
# gpg:                issuer "janek@keepassxc.org"
# gpg: Can't check signature: No public key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve user feedback when adding duplicate additional URL
2 participants