Fix several issues with Quick Unlock #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9697 +/- ##
===========================================
- Coverage 64.74% 64.73% -0.00%
===========================================
Files 337 337
Lines 44656 44667 +11
===========================================
+ Hits 28910 28915 +5
- Misses 15746 15752 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view. * Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown. * Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch. * Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior. * Disable quick unlock in gui tests
droidmonkey
force-pushed
the
fix/quickunlock
branch
from
fb84877 to
0d54361
Compare
|
While on the issue of QuickUnlock, the guide should also be clarified. I will again suggest that QuickUnlock should be opt-in, or at least have an explicit "Enable QuickUnlock" checkbox on the main Database Unlock widget, where you enter the full master password. I'm ok if the checkbox is checked by default, but it should be clearly visible (and toggleable). |
michaelk83
reviewed
Aug 6, 2023
|
The opt-in/out on the unlock dialog will be introduced in 2.8.0 along with pin-based quick unlock and Linux fprint support. |
phoerious
requested changes
Aug 7, 2023
phoerious
approved these changes
Aug 10, 2023
Closed
droidmonkey
added a commit
that referenced
this pull request
Aug 14, 2023
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view. * Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown. * Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch. * Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior. * Disable quick unlock in gui tests
libf-de
pushed a commit
to libf-de/keepassxc-secretservice-dbus
that referenced
this pull request
Aug 16, 2023
Release 2.7.6 Changes - Significant improvement to visual when drag/drop entries [keepassxreboot#9698] - Automatically prompt for Quick Unlock when showing unlock dialog [keepassxreboot#9697] - Improve colorful lock icon and fix file MIME icon on KDE [keepassxreboot#9632] - Ability to search by entry UUID [keepassxreboot#9571] - Add challenge-response support for NitroKey 3 [keepassxreboot#9631] - Auto-Type: Disable entry level Auto-Type when disabled at group/entry [keepassxreboot#9672] - Browser: Show warning when adding duplicate URL's to entry [keepassxreboot#9588][keepassxreboot#9635] - Browser: Improve error message when proxy cannot be found [keepassxreboot#9385] Fixes - Fix crash on exit on macOS [keepassxreboot#9620] - Fix crash on search if entry doesn't have a group [keepassxreboot#9633] - Fix several issues with Quick Unlock [keepassxreboot#9697] - Enable save button when not auto-saving non-data changes [keepassxreboot#9634] - Several UI/UX fixes [keepassxreboot#9647] - Move toolbar back to top of window when disabling movement [keepassxreboot#9699] - Browser: Fix closing password generator dialog with X button [keepassxreboot#9636] - Browser: Fix handling of expired credentials [keepassxreboot#9595] - Windows: Prevent white flicker when launching application [keepassxreboot#9637] - Linux: Fix warning message about allow screencapture [keepassxreboot#9638] - FdoSecrets: Fix access confirmation dialog showing even when disabled [keepassxreboot#9690] # -----BEGIN PGP SIGNATURE----- # # iQJIBAABCAAyFiEE6A9nU7OzJX8m9B8ILPQdKqhDj5kFAmTb/usUHGphbmVrQGtl # ZXBhc3N4Yy5vcmcACgkQLPQdKqhDj5l9vBAAmiCQR+L3ZLVq7CfXK+yOrCr1pV1J # H6znrRe4SC5MR/dyrx+EVbkaPI0aWtW/NWa4REB9BUxkbXKIPy/9M6smj3xkjAqX # YuYThNneRBFns9Rb5RyAIonwEXXmYHAWG2wdRXXFOnsb/Dxy9DYZK6+Ysbj55CQJ # RBJ1y0IKCuajLvENW9zQQ/vTX0oxCQ2F9Fz7aTqGIoxW6NMhjTso7IPvKYWPzbNj # FBOiI4kusL32pT5u+XwSUjmBvXrIEBjETYFTVgqesItAr0dFAgEh8f0jvuy8on8K # ukVzD02JqavkMfwtDsvUVLdVdr1PJMOu4/qDodR1xC39VOjS9LQ6dK8rb/1Q4/MR # cAXjBhNBZ0A5yq9XtdNvl8xYqkvYa/KcFuHUFwBoinLXtKLnh4aswDqk4caNeI4O # O40Nk5J4J6Qgs89XIsQHkXkGTaPxuISHVeFWWqcpX9kRJhtlt5eIS6nDv8nGx8iq # q65NfCldPckgmuIxeCX2lYtxieq09jAhD1/92eXsH1aNkZce4W1UcjGE58cduODd # oXV7VCo0JUzkMky9I9/G+hAqWwLp94D5ewYG8yX2Oz2jwcoWvZSIZ6MtR+2NiYpL # pFSFB/yoqWQOIVc9eHqCQl7rMMK66pJWwu7boxS22/xoNTAfzMwNtp8CmbLpqIhF # 7lPQiiC2DnqfR0E= # =l8kk # -----END PGP SIGNATURE----- # gpg: directory '/home/runner/.gnupg' created # gpg: keybox '/home/runner/.gnupg/pubring.kbx' created # gpg: Signature made Tue Aug 15 22:40:43 2023 UTC # gpg: using RSA key E80F6753B3B3257F26F41F082CF41D2AA8438F99 # gpg: issuer "janek@keepassxc.org" # gpg: Can't check signature: No public key
evur
pushed a commit
to BrokenMS/keepassxc
that referenced
this pull request
Aug 23, 2023
* Fix keepassxreboot#7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view. * Fix keepassxreboot#9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown. * Fix keepassxreboot#9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch. * Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior. * Disable quick unlock in gui tests
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Enable escape key to cancel Quick Unlock #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
Fix Direct QuickUnlock without prompting user to confirm unlocking attempt #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
Fix Always show Quick Unlock settings checkbox on Windows and MacOS #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.
Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue.
Disable quick unlock in gui tests
Screenshots
Testing strategy
Tested on Windows
Type of change