Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix first entry is not selected when a search is performed #9868

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Fix first entry is not selected when a search is performed #9868

merged 2 commits into from
Sep 25, 2023

Conversation

Colfenor
Copy link
Contributor

@Colfenor Colfenor commented Sep 22, 2023 •
edited
Loading

Attempt to fix #9865

first fetching the first row entry, setting it active and then sorting the entries by parent group

Testing strategy

  1. open a populated .kdbx database with entries associated to root and child groups
  2. search for a desired entry where multiple entries are returned as a list
  3. observe which entry is set active visible to the user by a light green entry coloration in the GUI

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@Colfenor Colfenor changed the title fix first entry is not selected when a search is performed Fix first entry is not selected when a search is performed Sep 22, 2023
@Colfenor
Copy link
Contributor Author

(MacOS build failing on TeamCity seems unrelated, according to the log some licence agreement update)

@droidmonkey
Copy link
Member

droidmonkey commented Sep 23, 2023 •
edited
Loading

We should add a test in TestGui::testSearch that checks if the first row is selected after a search is conducted

Btw, this PR does not fix the issue.

@droidmonkey droidmonkey added this to the v2.8.0 milestone Sep 23, 2023
@droidmonkey droidmonkey self-requested a review September 23, 2023 04:08
@droidmonkey droidmonkey marked this pull request as draft September 23, 2023 04:11
@Colfenor Colfenor force-pushed the fix/first-entry-is-not-selected-when-a-search-is-performed branch from 044b02a to c3f5909 Compare September 23, 2023 15:36
@Colfenor
Copy link
Contributor Author

updated the fix approach, TODO: write test for TestGui

@Colfenor Colfenor force-pushed the fix/first-entry-is-not-selected-when-a-search-is-performed branch from 058cd06 to 73fa860 Compare September 24, 2023 18:11
@Colfenor Colfenor force-pushed the fix/first-entry-is-not-selected-when-a-search-is-performed branch from 73fa860 to 5c6727f Compare September 24, 2023 18:12
@Colfenor Colfenor marked this pull request as ready for review September 24, 2023 18:13
@droidmonkey droidmonkey merged commit cd7a53a into keepassxreboot:develop Sep 25, 2023
2 checks passed
droidmonkey pushed a commit that referenced this pull request Jan 30, 2024
@Colfenor @droidmonkey
Fix first entry is not selected when a search is performed (#9868)
03e85c2
@droidmonkey droidmonkey mentioned this pull request Jan 30, 2024
Merged
droidmonkey pushed a commit that referenced this pull request Feb 4, 2024
@Colfenor @droidmonkey
Fix first entry is not selected when a search is performed (#9868)
762fd94
libf-de pushed a commit to libf-de/keepassxc-secretservice-dbus that referenced this pull request Mar 11, 2024
@release-bot
Merge tag 'tags/2.7.7' into proposed-2.7.7
a04ec08 
Release 2.7.7

- Support USB Hotplug for Hardware Key interface [keepassxreboot#10092]
- Support 1PUX and Bitwarden import [keepassxreboot#9815]
- Browser: Add support for PassKeys [keepassxreboot#8825, keepassxreboot#9987, keepassxreboot#10318]
- Build System: Move to vcpkg manifest mode [keepassxreboot#10088]

- Fix multiple TOTP issues [keepassxreboot#9874]
- Fix focus loss on save when the editor is not visible anymore [keepassxreboot#10075]
- Fix visual when removing entry from history [keepassxreboot#9947]
- Fix first entry is not selected when a search is performed [keepassxreboot#9868]
- Prevent scrollbars on entry drag/drop [keepassxreboot#9747]
- Prevent duplicate characters in "Also choose from" field of password generator  [keepassxreboot#9803]
- Security: Prevent byte-by-byte and attachment inference side channel attacks [keepassxreboot#10266]
- Browser: Fix raising Update Entry messagebox [keepassxreboot#9853]
- Browser: Fix bugs when returning credentials [keepassxreboot#9136]
- Browser: Fix crash on database open from browser [keepassxreboot#9939]
- Browser: Fix support for referenced URL fields [keepassxreboot#8788]
- MacOS: Fix crash when changing highlight/accent color [keepassxreboot#10348]
- MacOS: Fix TouchID appearing even though lid is closed [keepassxreboot#10092]
- Windows: Fix terminating KeePassXC processes with MSI installer [keepassxreboot#9822]
- FdoSecrets: Fix database merge crash when enabled [keepassxreboot#10136]

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEENIkEDB8MPuq41ValRA/GXy4MbgEFAmXs7VsACgkQRA/GXy4M
# bgHLpwf/brnyPPs3gJxZmD2pn8542D4CCsDh0fTceurOtqCe3J4Y+Fftc5euuoQu
# 6rP4vJdd586l7JX5FnYIPXvGiU9op3MudJh+y+RN/PWwKcXNIXfUItMhpZEka49n
# xnw+Wvbilg1QIHSSmZdIjBpohnEkA67qhWauc3bCacrRyEvIOzVMTxnqDTe4GUDy
# CyauaRMMKezRTpLxSsk63TDAZZgDwK4ci5lC6ysHekc1Za6IbI3fMFjz1BGj+kPU
# tMHMfDCWqK/5JZ27ZWcxy7m8tJY9m3rb+MoCyFRQz9ixaEe29yf5NqYdm9sn1Dlh
# O7aFi7/EJtsBlXdguw5BcTPbsL7XEQ==
# =Cots
# -----END PGP SIGNATURE-----
# gpg: directory '/home/runner/.gnupg' created
# gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
# gpg: Signature made Sat Mar  9 23:14:35 2024 UTC
# gpg:                using RSA key 3489040C1F0C3EEAB8D556A5440FC65F2E0C6E01
# gpg: Can't check signature: No public key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
backported bug feature: Search
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

First entry is not selected when a search is performed
2 participants
@Colfenor @droidmonkey