Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect multiple zeros as an invalid step #743

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

sheerlox
Copy link
Collaborator

Description

Please take a look at the related issue for more information.

Related Issue

Fixes #742.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added the type:bug Bug reports and bug fixes label Oct 23, 2023
@sheerlox sheerlox self-assigned this Oct 23, 2023
@sheerlox sheerlox force-pushed the fix/742/fix-zeros-step-infinite-loop branch from d233c31 to ab39ad4 Compare October 23, 2023 19:05
@sheerlox sheerlox removed their assignment Oct 23, 2023
tests/crontime.test.ts Outdated Show resolved Hide resolved
@sheerlox sheerlox merged commit b0bf677 into kelektiv:main Oct 25, 2023
11 checks passed
@sheerlox sheerlox deleted the fix/742/fix-zeros-step-infinite-loop branch October 25, 2023 21:23
ncb000gt pushed a commit that referenced this pull request Oct 26, 2023
## [3.1.5](v3.1.4...v3.1.5) (2023-10-26)

### 🐛 Bug Fixes

* detect multiple zeros as an invalid step ([#743](#743)) [skip ci] ([b0bf677](b0bf677))
* re-add runOnce property to CronJob ([#751](#751)) ([a61d8c9](a61d8c9))

### 📚 Documentation

* **readme:** API documentation overhaul ([#716](#716)) [skip ci] ([23fb0a3](23fb0a3))

### ⚙️ Continuous Integrations

* **action:** update actions/setup-node action to v4 ([#749](#749)) ([ef850f3](ef850f3))

### ♻️ Chores

* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18 ([#747](#747)) ([5ff1cf8](5ff1cf8))
* **deps:** update dependency sinon to v17 ([#748](#748)) ([9d61ff9](9d61ff9))
* **deps:** update linters ([7bdc726](7bdc726))
* improve ossf scorecard's score ([#715](#715)) [skip ci] ([1284df4](1284df4))
@ncb000gt
Copy link
Member

🎉 This PR is included in version 3.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type:bug Bug reports and bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cron runs into infinite loop when providing two or more zeros as step
3 participants